Conditionally add -lnuma when building http_example about dpdk-ans HOT 12 CLOSED

In my ubuntu 16.04, needn't -lnuma.

from dpdk-ans.

This is a real issue. I can send logs. This may be because the host I am compiling on didn’t have numa support.

Concerning that this was closed without discussion.

from dpdk-ans.

Used dead account to comment. Sorry, will use this one next time.

from dpdk-ans.

Close this discussion for no any reply. -:)
I know that shall add -lnuma to the LDLIBS in ubuntu 16.10.
I think user can change the makefile based on their system. or do you have any idea to fix such issue?

from dpdk-ans.

NUMA is used within librte_eal for the malloc_* operations. If the original author had NUMA enabled during the compilation of EAL then that library will already be included during loading.

This is an issue for me because the makefile lib/librte_eal/linuxapp/eal/Makefile optionally configures NUMA based on CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES.

http_example uses the NUMA library to detect if the NUMA enabled calls are needed. It should be added to the LDFLAGS since adding it redundantly will not negatively effect anything.

I do not have a NUMA enabled machine to test this.

from dpdk-ans.

In my ubuntu 16.04 env, if add -lnuma to LDFLAGS, will have below errors.
I think -lnuma only impact on glibc memory malloc, won't impact on dpdk memory malloc.
gcc -c -O3 -I/root/src/dpdk-ans/librte_ans/include -I/root/src/dpdk-ans/librte_anssock/include http_server.c -o http_server.o
gcc -o http_server http_server.o -O3 -I/root/src/dpdk-ans/librte_ans/include -I/root/src/dpdk-ans/librte_anssock/include /root/src/dpdk-ans/librte_anssock/librte_anssock.a -L/root/src/dpdk-17.02/x86_64-native-linuxapp-gcc/lib -Wl,--whole-archive -Wl,-lrte_mbuf -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal -Wl,--no-whole-archive -Wl,-export-dynamic -lrt -pthread -ldl -lnuma
/usr/bin/ld: cannot find -lnuma
collect2: error: ld returned 1 exit status
make: *** [http_server] Error 1

from dpdk-ans.

I do not know why you do not have libnuma installed. This was from a clean install with no source modification (pull from master).

Looks like DPDK can conditionally need NUMA libraries and the ANS makefile is not written to detect if it is needed.

from dpdk-ans.

libnuma is in glibc，only glibc in ubuntu16.10 need that.
dpdk needn't libnuma, dpdk has owner memory management to detect numa.

from dpdk-ans.

Your above comments make absolutely no sense.

libnuma is not part of glibc. It is an external library that is automatically installed by the distribution.

'dpdk' specifically uses libnuma:

librte_eal/linuxapp/eal/eal_memory.c
56:#include <numa.h>

This is a simple issue: your build system makes the false assumption that libnuma will never be used.

from dpdk-ans.

ok
dpdk-17.08 has RTE_EAL_NUMA_AWARE_HUGEPAGES. but dpdk-17.05 hasn't it.
Currently ans support dpdk-17.05 . ans will support it when integrate dpdk-17.08.
Thanks for your comments.

from dpdk-ans.

Greatly appreciated!! Sorry that I got frustrated.

from dpdk-ans.

ans already support dpdk-17.11.2.
Fix this issue.

from dpdk-ans.