Giter Club home page Giter Club logo

Comments (5)

shanemcd avatar shanemcd commented on August 21, 2024

Rather than putting the Dockerfile outside of the context directory. I think we should always put the stuff that’s ADDed under a sources/ directory (call it whatever).

from ansible-builder.

AlanCoding avatar AlanCoding commented on August 21, 2024

^ Everyone says keeping a lightweight build context is a best practice, and if you're putting the context at the top level of the project, there's going to be a bunch of who-knows-what which gets into that same folder, like .git, Zuul config, etc...

Managing a custom path for the Dockerfile might get a little ugly, but not as bad as people throwing around .dockerignores all over the place

EDIT: or maybe the "sources" directory becomes the build context... I'm not sure if that works or not, will have to think on it.

from ansible-builder.

pabelanger avatar pabelanger commented on August 21, 2024

^ Everyone says keeping a lightweight build context is a best practice, and if you're putting the context at the top level of the project, there's going to be a bunch of who-knows-what which gets into that same folder, like .git, Zuul config, etc...

Managing a custom path for the Dockerfile might get a little ugly, but not as bad as people throwing around .dockerignores all over the place

EDIT: or maybe the "sources" directory becomes the build context... I'm not sure if that works or not, will have to think on it.

I like the idea of 'sources' folder inside of context, which is where Dockerfile live. I'm going to hack on it this weekend, to see if I can come up with a POC.

from ansible-builder.

AlanCoding avatar AlanCoding commented on August 21, 2024

I'm tripping over terminology now. The Dockerfile doesn't need to be in the build context, so when this sources folder is proposed, it makes sense that that becomes the build context, only problem is that ansible-builder build already has a CLI option for the build context.

from ansible-builder.

AlanCoding avatar AlanCoding commented on August 21, 2024

Closed with #157, which finalized on the _build directory.

See awx-ee

https://github.com/ansible/awx-ee/tree/devel/_build

network-ee has also been updated.

from ansible-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.