Giter Club home page Giter Club logo

Comments (4)

rpelisse avatar rpelisse commented on August 28, 2024 1

I think we cannot get away without providing a way for user to have their own zipfile instead of our sane defaults. One use case I can see is an organization building its own, customized version of JWS, zipping in under my-org-java-server-1.1.zip. We need to have path for this use case.
However, yes, we should not have tomcat_zipfile has a mandatory parameters to provides, but more as an option.

from jws.

csutherl avatar csutherl commented on August 28, 2024

In case anyone hits this issue, I wanted to drop a note so that it's searchable :) I experienced it by accident after running the playbook twice and upgrading from 9.0.50 to 9.0.62 in between (without deleting tomcat.zip first). I think adding this feature would make the playbook much more robust. Output:

TASK [middleware_automation.jws.jws : Ensure service script is deployed] ***************************************************************************************************************************************************************************************************************************************************** fatal: [localhost]: FAILED! => {"changed": false, "checksum": "6c5a8239a5be03ff60caa24cca027067b8eddc84", "msg": "Destination directory /opt/apache-tomcat-9.0.62/bin does not exist"}

from jws.

guidograzioli avatar guidograzioli commented on August 28, 2024

The cause of this issue is that we allow to override the installation zipfile to a file name that does not contain the version.
tomcat_zipfile: "tomcat.zip"
There is no clean way to check if an arbitrarily named zipfile really contains what is declared in tomcat_version.

I think we should remove the option tomcat_zipfile completely; and instead rely on what filenames are provided by the download enpoints

from jws.

guidograzioli avatar guidograzioli commented on August 28, 2024

Parameter tomcat_force_install introduced in #80 allows to perform the update (no uninstall happens); setting a tomcat_version (and thus tomcat_home) which does not match with the contents of zipfile continues to throw an error. We might want to use a better wording than 'Destination directory /opt/apache-tomcat-X.X.X does not exist`?

from jws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.