Comments (4)
I think we cannot get away without providing a way for user to have their own zipfile instead of our sane defaults. One use case I can see is an organization building its own, customized version of JWS, zipping in under my-org-java-server-1.1.zip. We need to have path for this use case.
However, yes, we should not have tomcat_zipfile has a mandatory parameters to provides, but more as an option.
from jws.
In case anyone hits this issue, I wanted to drop a note so that it's searchable :) I experienced it by accident after running the playbook twice and upgrading from 9.0.50 to 9.0.62 in between (without deleting tomcat.zip first). I think adding this feature would make the playbook much more robust. Output:
TASK [middleware_automation.jws.jws : Ensure service script is deployed] ***************************************************************************************************************************************************************************************************************************************************** fatal: [localhost]: FAILED! => {"changed": false, "checksum": "6c5a8239a5be03ff60caa24cca027067b8eddc84", "msg": "Destination directory /opt/apache-tomcat-9.0.62/bin does not exist"}
from jws.
The cause of this issue is that we allow to override the installation zipfile to a file name that does not contain the version.
tomcat_zipfile: "tomcat.zip"
There is no clean way to check if an arbitrarily named zipfile really contains what is declared in tomcat_version
.
I think we should remove the option tomcat_zipfile completely; and instead rely on what filenames are provided by the download enpoints
from jws.
Parameter tomcat_force_install
introduced in #80 allows to perform the update (no uninstall happens); setting a tomcat_version (and thus tomcat_home) which does not match with the contents of zipfile continues to throw an error. We might want to use a better wording than 'Destination directory /opt/apache-tomcat-X.X.X does not exist`?
from jws.
Related Issues (20)
- jws_version must always be a full release. HOT 4
- Service patches don't always have base and native zips. HOT 4
- Rename Github repository to 'jws' to follow convention HOT 1
- Missing dependency when selinux policy is used. HOT 4
- JWS playbook/configuration to be used as examples. HOT 3
- Organize jws role documentation HOT 5
- Sanity checks may hinder users when custom templates are used. HOT 6
- AJP connector mentioned in HTTPS sanity checks. HOT 1
- groupinstall of jws rpm installation does not execute HOT 1
- By default, the collection should NOT remove ROOT and docs from the webapps. HOT 1
- When tomcat_vault is enabled, installation with rpm should also installed the required package HOT 1
- Invalid file mask for configuration file HOT 1
- Use jinja2 exists instead of stat: when file lives on controller HOT 1
- Replace computation of PWD by defaults value
- Vars documentation is missing for HTTS default setup HOT 1
- Invalid value in readme
- Preinstalled Java HOT 5
- Natives patch not applied. HOT 6
- Selinux is not working. HOT 2
- Collection doesn't recognize native resources zip with new JWS version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jws.