Giter Club home page Giter Club logo

Comments (4)

timothy1ee avatar timothy1ee commented on June 17, 2024

Next time, definitely ask early in the Facebook group, I can probably save you a lot of time.

Your implementation is generally excellent from a code quality perspective (which is great), but I don't like that you completely dodged any custom cells in your filter view. A major point of the homework was managing embedded controls in custom cells and tying the control events back to your model.

Can you revisit this and add a custom cell to your filters with a UISwitch that is bound to some data? By the way, you should consider discussing homework with your group, Liron's homework is outstanding, haven't seen Ning's homework yet.

from yelply.

annado avatar annado commented on June 17, 2024

Sure I can add the custom TableCell later this week. That probably makes
more sense and explains why FiltersView code is such a mess.

On Wednesday, March 26, 2014, Timothy Lee [email protected] wrote:

Next time, definitely ask early in the Facebook group, I can probably save
you a lot of time.

Your implementation is generally excellent from a code quality perspective
(which is great), but I don't like that you completely dodged any custom
cells in your filter view. A major point of the homework was managing
embedded controls in custom cells and tying the control events back to your
model.

Can you revisit this and add a custom cell to your filters with a UISwitch
that is bound to some data? By the way, you should consider discussing
homework with your group, Liron's homework is outstanding, haven't seen
Ning's homework yet.

Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-38659013
.

Sent from my iPhone

from yelply.

annado avatar annado commented on June 17, 2024

@timothy1ee just added the custom Filter cells

from yelply.

timothy1ee avatar timothy1ee commented on June 17, 2024

Great, looks good.

from yelply.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.