Get rid of fromInternal/toInternal functions in favor of generics about protoc-gen-elm HOT 3 CLOSED

One issue I ran into when trying to implement this were recursive oneof types such as this one:

message LayerOne {
  repeated LayerTwo layerTwo = 1;
}

message LayerTwo {
  oneof msg {
    LayerOne layerOne = 1;
  }
}

Previously, there was no recursion issue here since we generated

type Msg = LayerOne LayerOne

which stops the recursion since it is not a type alias.

Now we want to generate

// Package.Msg.elm
type Msg a = LayerOne a
// Package.elm
type alias Msg = Msg LayerOne
// this expands into type alias Msg = Msg { msg: List LayerTwo }
// expands into type alias Msg = Msg { msg: List (Msg LayerOne ) }
// etc.

So similarily to directly recursive declarations like this one

message Rec {
  oneof msg {
    Rec rec = 1;
    string other = 2;
  }
}

we need to generate wrapper types and wrap/unwrap functions.

from protoc-gen-elm.

This feature is released in a 4.0.0-beta.0 version :)

from protoc-gen-elm.

Alright, I released 4.0 which generates this kind of code :)

from protoc-gen-elm.