Comments (3)
Hey @jfloff, I added a test case for this and was also unable to reproduce manually. No search record is created with execute: false
.
searchjoy/test/searchjoy_test.rb
Line 47 in bdeba4d
from searchjoy.
Hi there,
You are right, after your answer I was able to narrow it down a bit more and found out that some actions are triggering multiple Searchjoy entries. This was one of my test cases:
products = Product.search("apples")
5.times do
products.suggestions
end
This is creating 5 entries on Searchjoy. I suspect other actions such as getting the results, are also creating multiple Searchjoy entries. Looks like Searchjoy is not taking into consideration that the data is already loaded and any method call is accounted as a search.
from searchjoy.
Hey @jfloff, I'm not able to reproduce that either (with Searchjoy 0.3.2 and Searchkick 3 and 4). I just pushed a new version (Searchjoy 0.4.0) to add tracking to Searchkick.multi_search
. If you're still having issues with the latest version, please create a PR a with a failing test case.
from searchjoy.
Related Issues (20)
- Missing tests HOT 1
- Custom tracking fields do not work with Rails 3 (or Rails 4) w/o strong parameters HOT 2
- Adding a non-concurrent index locks the table. HOT 1
- Can't mass-assign protected attributes for Searchjoy::Search: user_id, source HOT 3
- Not track search when searching multiple models HOT 1
- Unused Eager Loading detected HOT 1
- Errors when using Searchkick with option execute => false
- Index name too long SQLite HOT 1
- Rails API Only Support HOT 1
- On Migration (index too long) HOT 8
- Routing error HOT 1
- `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x00007fc2af60afd0> (NoMethodError) HOT 2
- Fails with Sprockets 4.0.0 HOT 2
- exception from groupdate gem HOT 3
- How to use with autocomplete HOT 4
- User track with multiple models HOT 1
- Multiple conversions per search HOT 3
- Conversion tracking one-to-many query-to-conversions HOT 4
- Searchjoy::Search convert method undefined. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from searchjoy.