Comments (27)
After cloning the repo I can see why the extension hasn't been updated on the Chrome Webstore lol. Although, after a bit of tinkering I seem to have gotten most of it working again and I'd be more than happy to fix things up around here to have a stable version.
from ac-music-extension.
Mine is [email protected] 👍
@JdotCarver you may have a look at PikaDude's repo to see the improvements made.
@PikaDude deserves most of the credit, huge kudos to him!
from ac-music-extension.
Finally, the last thing I'll do is update the readme with a temporary note that development is currently happening in that repo, in case more collaborators are interested!
from ac-music-extension.
I agree with the ownership change, personally. However, it is not needed to create a new separate published extension as the original license only says that if we are to modify it then we must have it under a different name (perhaps append a word to the title like "revived") and make it clear that it is a modified version by doing so. We could just change the name of the extension and be done with that.
from ac-music-extension.
Sounds good. I've gone ahead and forked the repository here and I've also made some small refinements, fixes and changes to get it working again. I'm currently in the process of re-organizing all of the music in their folders, getting event music working properly again, and updating the town tune sounds to be more accurate to the game. I have access to a hacked 3DS so I'm using that to dump any needs sounds from my copies of the games. I also have a lot of experience with bulk editing sounds so I'm also adjusting the format of and increasing the quality of the songs according to issue #9.
from ac-music-extension.
Hey @PikaDude, I'd love to help contribute to this project. I can try to update the UI to make it look similar to the in-game Town Tune editor.
from ac-music-extension.
Sure, @anokhee. You're more than welcome to contribute to it. Just fork my fork and make a PR whenever you're ready.
from ac-music-extension.
Thanks, @paladique, I'll probably continue in my own repo for now and merge the changes once they're all finished.
from ac-music-extension.
@jordigarcl I see you're working on this too, so I'm giving ya write access!
from ac-music-extension.
@paladique This is great! I agree the best course of action is to keep working on @PikaDude 's fork and then integrate everything here once it is ready to go.
In the meanwhile we can trim this repo issues as you have already done 👍
from ac-music-extension.
@paladique Just joined the Discord Group. I'm connected 80% of the day so you'll be sure to find me there. :)
from ac-music-extension.
Thank you for the invite!
from ac-music-extension.
Hey there,
Yeah I never had the skills to figure out all of this by myself and other projects came by and swept this one under the rug. I'd be happy to have you help out! A lot of people have contributed to this project and their work remains unpublished because of the conflicts I'm unable to resolve. But if you say you managed, that would be great.
from ac-music-extension.
Is it maybe possible for me to receive write access so I can merge pull requests and maybe make commits directly? It'd make things a lot easier.
from ac-music-extension.
I would also love to be able to contribute to this project! Found out about it on Twitter and have been lurking the repo for a couple days.
I noticed that there is already a perfectly working version published on the Chrome Store, but the new contributions have not been published and the current state of the project crashes.
It is a pity that the work that has been contributed to this project remains unpublished due to (understandable) lack of experience and manpower! I think that, with some proper maintenance, we should be able to fix the issues with the current state of master
so it can be properly published to the store. After all, most of the bugs that make the project crash in its current state seem to be trivial.
If the current project owner is not able to actively maintain the project anymore, perhaps we should evaluate an ownership change. Further work on the extension could continue as a new, separately published extension (honouring the original project license) and the owner could point new users/contributors to the new extension/repository, while maintaining the integrity of this project.
from ac-music-extension.
I agree that updating the currently published extension would be the best option to continue development, as we would be able to deliver all unpublished features to the existing user-base.
However, given that the latest Chrome version is almost 4 years old, I'm willing to bet that the maintainers are reluctant to update an already stable version, specially if they feel that they can't ensure its integrity.
In addition to fixing the current issues that break the extension, I personally want to rework the project: updating the extension, reworking the repo readme, cleaning up opened issues, updating the chrome extension page, refactoring parts of the code and even creating a simple GitHub Page for end-users.
Since these kind of changes need a higher degree of control and involvement than the one than the one possible through PRs, I propose the following:
-
We could fork the repository and work on all things mentioned above.
-
Once we reach a stable version, we can evaluate either updating the original repo with all changes from the fork, or making this new repo the de-facto one.
-
Ideally we could publish all new changes to the existing extension, and if you guys are unwilling to do that, then we could publish a new one and at least markthe original as "discontinued", mentioning the new one in its description.
TL;DR: We want to take an active role in the project maintainance/revival. Collaboration of the current project owners would enable us to deliver these new changes to the existing userbase. I have proposed a few ways to do this safely! 😉
from ac-music-extension.
Well I can say it's pleasant to see you working things out! Tell me if I can do anything to help you in the process. 👍
from ac-music-extension.
Hi everyone! I wanted to contribute over the summer but work got super busy, but @PikaDude I also have write access and can add ya!
from ac-music-extension.
@PikaDude I went ahead and added you with write access, I like your ideas of reviving this. You should have enough permissions to triage issues and PRs and push access.
from ac-music-extension.
Sounds good. I believe I have access to publish as well, so we can work through that once it's time and you think it's in a good spot. :) I'll check out your repo and help out too when I can.
from ac-music-extension.
@JdotCarver 👋! so we are almost ready to publish a new version, however none of us have access to to Google group to do this. You sent me an invitation over the summer but apparently I never accepted and it expired 😭 Could you provide us access? I'll still use the same email as last time: [email protected]. @jordigarcl and @PikaDude you can share yours here too or I'll invite you when I accept mine.
from ac-music-extension.
Oh! and @JdotCarver is there a place where we can communicate with you from time to time with questions if we have em? email? the discord group?
from ac-music-extension.
My email is [email protected]
Also thanks, @jordigarcl! I honestly appreciate the help everyone's given too.
from ac-music-extension.
Hey, @JdotCarver, any updates on giving us permission to publish the extension? We are just about finished.
from ac-music-extension.
Invitations to the Google Publishing Group sent!
And @paladique you are already in the Google Group as indicated in the members page here:
PS: I also moved your status to Owner of the group.
from ac-music-extension.
How do we stand in this issue? Now that we have merged a lot of changes into the repo, I'd say the extension is actively maintained again :)
from ac-music-extension.
Yeah, we should be good to close this now.
from ac-music-extension.
Related Issues (20)
- Suggestion: Website/Webstore music HOT 1
- (feature request) Play random looping ambiance from NH HOT 1
- Unknown Error Trying to update zip location HOT 1
- Google Drive link doesn't include New Horizons music HOT 5
- Live Weather Location HOT 1
- Error when inputting live weather location HOT 4
- Official Firefox Version Please? HOT 1
- Certain songs don't quite loop properly HOT 1
- Improve transitions between songs when using Live Weather feature
- missing from Chrome Web Extensions Store HOT 3
- Even more customization
- Removed chrome extension page HOT 2
- Animal Crossing GCN Rain music
- Getting it working on Opera GX
- make it so you can play midi files
- It doesn't appears in the Chrome Web Store HOT 4
- Extension not available anymore on the Chrome Web Store HOT 1
- Midi
- Add Rain Sounds To Rain Music
- Town tune plays multiple times simultaneously
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ac-music-extension.