e2e test for ServerDomRenderer and with preboot.js about universal HOT 16 CLOSED

I'm working on this now

from universal.

I'm not sure how to get element props with protractor to test client rendered elements and selection

from universal.

Hi @gdi2290 have you started this?

from universal.

@manekinekko I push up the wip. the problem is getting the props rather than the attrs
https://github.com/angular/universal/blob/master/test/test_page.e2e.js
you would need to inject js to grab elements and expose them to protractor I think

from universal.

@gdi2290 which props do you wanna test? I managed to read pros from DOM element.

from universal.

@manekinekko the input to ensure selection is correct and the value of the input

from universal.

@gdi2290 using executeScript you can run arbitrary js code. So for example, this gives you the value property:

it('should have default value for inputs', function() {
  subject = browser.executeScript('return document.querySelector("#defaultValueInput").value');
  result  = 'value8';

  expect(subject).toBe(result);
});

from universal.

oh that's a good find and solves a lot of problems 👍

from universal.

should I emphasis on the difference between the prop "value" and the attribute "value" in the test suites?

from universal.

yup, although for server only it's attrs while everything else it's props it's important to note that

from universal.

@gdi2290 here is what I was able to test so far. As you can see from the screenshot below, there is one test that fails and 3 pending test that I don't know how to test (the preboot ones).
I let you check that if you dont mind ;)

If you're OK. I'll send the PR right away.

from universal.

LGTM

from universal.

selection isn't really working with preboot or at least not with the e2e tests

from universal.

@jeffwhelpley can you take a look at the e2e tests to see why it's failing
https://github.com/angular/universal/blob/master/test/test_page.e2e.js#L86...L103

from universal.

done via ae31bd2

from universal.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

from universal.