subclasses with different constructor params break static call method gen about clutz HOT 5 CLOSED

+1 on not emitting call/apply for ctors, AFAIK it's even illegal to use
apply on an ES6 class, so this is bound to only cause confusion.

Rado Kirov [email protected] schrieb am Mi., 2. Sep. 2015 um
02:47 Uhr:

For example if B extends A and takes string instead of number, we generate:

declare namespace f {
class A {
constructor(n: number);
static call(a: A, n: number);
}

class B extends A {
    constructor(s: string);
    static call(b: B, n: string);
}

}

TS barfs on the static call for B which is required to subtype A's
functional type. See 'oog.fx.dom.PredefinedEffect' and 'Animation' for
closure lib repro.

Maybe we should not output call and apply for constructor functions until
someone really needs them. I can't come up with a good need for using those
in sane TS code.

—
Reply to this email directly or view it on GitHub
#76.

from clutz.

Turns out these static methods are only output if they are used somewhere else (most likely for implementing super constructor calls).

from clutz.

I can't get the following Closure code to compile in our test harness:

/**
 * @constructor
 * @param {number} n
 */
multi_class.A = function(n) {
  /** @type {number} */
  this.a = n;
};

/**
 * @constructor
 * @extends {multi_class.A}
 */
multi_class.B = function() {
  /** @type {number} */
  this.b = 1;
  multi_class.A.call(this, 0);
};
goog.inherits(multi_class.B, multi_class.A);

with error java.lang.AssertionError: JSC_UNDEFINED_NAME. multi_class.A.call is never defined at test.js line 21 : 2

Closure complains that it can't find call on multi_class.A, even though that's the pattern that goog.fx.dom.PredefinedEffect and subclasses use.

Works fine in the standalone cl compiler which probably means we are have some different flag setting.

from clutz.

cc @MatrixFrog

from clutz.

I think it would still be good to know why the type system works this way, but I suspect the new type system is a little more sane so I'm not overly worried about it.

from clutz.