AST is changed by closurePass about clutz HOT 5 CLOSED

Not sure what you mean by "attach properties".

There are two issues in the code above: goog.string.Unicode is not a valid variable identifier, and if this module is providing goog:goog.string.Unicode it should do an export default var ....

The latter is a bit muddy on the Closure side as there is no syntax to express the case of exporting an object that has properties and is exports vs a module that exports multiple things separately (functions, vars, etc). We should be able to figure that out based on the goog.provides though.

from clutz.

I'm not sure either - we looked at this one together and you said a bunch of stuff was missing from the string.js because some properties are not present. Like where is startsWith ?

from clutz.

I see. My understanding is that the problem is that goog.string does this:

goog.provide('goog.string');

goog.string.a = function() {};
goog.string.b = function() {};
...

Apparently c2dts doesn't handle that for some reason?

from clutz.

Problem is related to turning on closure pass. Instead of a null symbol.getType(), it is wrapped as an object literal type.

from clutz.

A simple repro of the current bug is

goog.provide('a');

/**
 * @param {number=} opt_precision
 * @return {string}
 */
a.b = function(opt_precision) {
    return goog.isDef(opt_precision) ? a.c(opt_precision) : "undef";
};

/**
 * @param {number} s
 * @return {string}
 */
a.c = function(s) {
    return String(s);
};

If I run this through current closure-to-dts at head, I get

java.lang.AssertionError: JSC_TYPE_MISMATCH. actual parameter 1 of a.c does not match formal parameter
found   : (number|undefined)
required: number at test.js line 8 : 43

from clutz.