Giter Club home page Giter Club logo

Comments (3)

nezo avatar nezo commented on May 5, 2024

Hi !

I had the same reactions when I saw these tests.

I had a hard time finding out what would be the best way to refactor, but here is what I came out with : nezo@b6a4725

What I did was merely moving all XHR related tests to servicesSpec.js and creating a mock Phone, in order not to deal with XHR from controllersSpec.js at all.

Please, feel free to give feeback !

from angular-phonecat.

Splaktar avatar Splaktar commented on May 5, 2024

I had this same issue. I expected there to be useful service tests in servicesSpec.js but it was just empty. I ran into other failures (with the latest Karma) as well and reported them in the wrong place (angular/angular.js#4769).

from angular-phonecat.

petebacondarwin avatar petebacondarwin commented on May 5, 2024

See #166

from angular-phonecat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.