Comments (7)
alexeagle
commented on May 4, 2024
maybe @thelgevold would like to help curate the example?
from angular-bazel-example.
thelgevold
commented on May 4, 2024
@alexeagle What did you have in mind for the sample? Are you thinking we should add a more interesting demo component?
from angular-bazel-example.
alexeagle
commented on May 4, 2024
This issue is just to make the current example conform to the style guide.
I think separately, there's an interesting project in making a broader
example that shows more stuff, like dev RTT at scale, server-side
rendering, routing, etc.
…On Fri, Feb 9, 2018 at 4:59 PM Torgeir Helgevold ***@***.***> wrote:
@alexeagle <https://github.com/alexeagle> What did you have in mind for
the sample? Are you thinking we should add a more interesting demo
component?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I4syYbiCU3e9_xtNppjLmqnN440jks5tTOnYgaJpZM4PeBJY>
.
from angular-bazel-example.
thelgevold
commented on May 4, 2024
Hm.. Maybe I am missing something, but isn't the sample already following the style guide pretty closely?
Looks like the only thing I am seeing is the import { SomeSymbol } vs import {SomeSymbol} convention. The style guide seems to favor trailing and leading spaces in import statements.
From what I can tell, the auto formatter removes this though.
from angular-bazel-example.
thelgevold
commented on May 4, 2024
I see some file name violations as well. I can make a PR.
from angular-bazel-example.
alexeagle
commented on May 4, 2024
We can change the formatter to prettier.
…On Mon, Feb 12, 2018 at 6:01 PM Torgeir Helgevold ***@***.***> wrote:
I see some file name violations as well. I can make a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I0zUeTpLVMJomry2S2aIgoOl3-9uks5tUOz3gaJpZM4PeBJY>
.
from angular-bazel-example.
alexeagle
commented on May 4, 2024
I think this is good enough!
from angular-bazel-example.
Related Issues (20)
- Remove need for rxjs_shims HOT 2
- breakage on latest master? HOT 2
- node option about rollup_bundle
- How to enable remote execution with language servers for `TypeScriptCompile` and `AngularTemplateCompile` actions HOT 3
- What is the current state of Converting an Angular CLI workspace? HOT 1
- Question: index.html and injected js HOT 3
- Question: Debugging on upgrade HOT 2
- question: Experimental Support for Ivy in Bazel? HOT 2
- cannot be named without a reference to '../../external/npm/node_modules/@angular/animations/animations' HOT 3
- Service Worker HOT 3
- Remove ngfactory deps HOT 4
- Multiple Node Projects Single WORKSPACE FILE HOT 8
- Already install @bazel/ibazel but still not running on window HOT 4
- Cannot find nodejs when running bazel run //src:devserver HOT 2
- Cannot import with module_name only with path HOT 1
- cannot import with path mappings from tsconfig.json HOT 3
- Bazel + Ivy (--define=compile=aot) fails with TS-966002 HOT 5
- Using Bazel in Application using Library HOT 1
- importHelpers breaks ng test HOT 1
- Bazel errors when building targets with rxjs deps HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-bazel-example.