Consider adding renovate to pin and track dependencies about angular-bazel-example HOT 12 CLOSED

Interesting, I do need something to tell me when upstream repos are working.
I also need to change WORKSPACE file to pick up rules_nodejs versions, so I think I'd have to write my own or maybe fork Renovate? but if they host that as a service, I don't want to have to own my own version of that.

from angular-bazel-example.

maybe @rarkins can help

from angular-bazel-example.

Hi @alexeagle, I'm the author of the Renovate tool/app. Are you referring to keeping syntax like the following up-to-date?

git_repository(
    name = "build_bazel_rules_nodejs",
    remote = "https://github.com/bazelbuild/rules_nodejs.git",
    tag = "0.1.0", # check for the latest tag when you install
)

from angular-bazel-example.

I've added bazel WORKSPACE awareness to a WIP branch and tested it on a fork of this repository. You can see the resulting Pull Requests here: https://github.com/renovate-tests/angular-bazel-example/pulls

Two are for bazel references and one is a regular package.json one for upgrading Typescript.

@alexeagle does this look ok?

from angular-bazel-example.

from angular-bazel-example.

@alexeagle yes, it's now live on the hosted app. If you go to https://github.com/apps/renovate you can choose to "Install" it and then given the option of installing on all repositories or select individual repositories one by one. It should work well with this repository as I used it for my testing.

from angular-bazel-example.

from angular-bazel-example.

@alexeagle thanks for the info regarding write permissions. As you suspected, Renovate currently works by creating branches within the repository itself. I will need to research if there's a way to implement using forks. GitHub Apps/bots are not "real" users so I'm not sure they can actually own their own fork of repos. On the other hand I'm not sure if they are able to submit PRs from a "real" user's repository.

from angular-bazel-example.

GitHub has that"pencil" feature in the UI where I propose some edit in a repo I don't have write access to.
It creates a fork dynamically I guess
Maybe that has an API?

from angular-bazel-example.

“Create a fork” is definitely in the API. The problem is that apps can’t “own” forks so they can’t call it on their own behalf - only on behalf of users, which wouldn’t make sense here. The solution may be to actually run as an old fashioned bot user account instead. Anyway I’ll raise an issue in the Renovate repo for describing and planning this requirement.

from angular-bazel-example.

I think this issue can be closed now 🎉

@alexeagle FYI, adding a "fork mode" like you suggested turned out to be pretty easy. I will be creating a second Renovate app on github which requires less repository permissions and submits all PRs from its own forked repositories using this mode.

Another change you may notice is that the bot is now GPG signing all its commits, in case that's of interest to you.

from angular-bazel-example.

Pretty awesome, I just approved the onboarding PR and I'll give you feedback. This is something all Angular users could benefit from!

from angular-bazel-example.