Merge tern def/plugin selection in the same treeview about tern.java HOT 15 CLOSED

@vrubezhny @dgolovin @mickaelistria @maxandersen @pascalleclercq @gamerson @paulvi could you please give me your comment about this issue, because I think it's important to know your opinion about the new UI to select tern defs/plugins.

Thank's!

from tern.java.

I've not used Tern so I'm just guessing, but I indeed think that a single treeviewer for those 2 items seem better that 2. Indeed, a user who wants to "hack" is tern configuration would most likely want a single entry point.
If you need to name a view, I'd simply call it "Tern".

from tern.java.

Thank's a lot @mickaelistria for your answer. I will do that.

Today we have in the project preferences :

Tern 
 -> Plugins
 -> Type Definitions

to select JSON Type Definitions (simple JSON) and Tern plugin (javascript which uses JSON Type Definitions)

I wil remove Type Definitions entry to merge Plugins+Type Definitions :

Tern 
 -> Plugins

If somebody wishes other label than "Plugins", don't hesitate to give me a suggestion.

Thank's!

from tern.java.

For your info, I have finished this issue. I have decided to use "Facets" instead of using "Plugins" :

• Facet is used to define "Plugins" and "JSON Type Definitions"
• Facet is used too for "Project Facets" which gives some features like Java, Javascript, CXF, etc

Here a screenshot of the new UI Tern Facet project property to select "Plugins" and "JSON Types Definitions" :

You can notice too that there are now icons for each "Plugins" and "JSON Types Definitions"

Hope you will like it.

from tern.java.

Looks nice... if you wanted to avoid the word "facets" because that is used
in the faceted project framework already, what if you called it "Tern >
Extensions"?

On Wed, May 21, 2014 at 3:30 PM, Angelo [email protected] wrote:

For your info, I have finished this issue. I have decided to use "Facets"
instead of using "Plugins" :

• Facet is used to define "Plugins" and "JSON Type Definitions"
• Facet is used too for "Project Facets" which gives some features
  like Java, Javascript, CXF, etc

Here a screenshot of the new UI Tern Facet project property to select
"Plugins" and "JSON Types Definitions" :

[image: ternfacets]https://cloud.githubusercontent.com/assets/1932211/3037184/95fa6f26-e0b9-11e3-98a5-994eaf221b2a.png

You can notice too that there are now icons for each "Plugins" and "JSON
Types Definitions"

Hope you will like it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-43721494
.

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com

from tern.java.

I'm somehow surprised to see that there is no "JavaScript" top category.
Tern and Angular could fit in.
Don't you depend on JSDT ?

from tern.java.

you called it "Tern >Extensions"?

I prefer using "Facet" instead of using "Extension", because Eclipse user are famliliar with "Facet" (you add some capabilities to your project). But if you prefer "Extension", I will change it.

I'm somehow surprised to see that there is no "JavaScript" top category.

"JavaScript" top category is ecma5 JSON Type Definition, I would like to avoidd changing the original name.

Tern and Angular could fit in.

Tern is the inference Javascript engine which is configured with plugins, JSON Type Definition. AngularJS Eclipse is based on the Tern plugin angular.

Don't you depend on JSDT ?
Yes and no:)

Tern IDE UI doesn't depends on JSDT. So you could use tern.java for other editor kind.

The project https://github.com/angelozerr/tern.java/tree/master/eclipse/tern.eclipse.ide.jsdt is a bridge between Tern and JSDT : it defines for instance compeltion extension for JSDT with tern.

from tern.java.

I don't have a strong preference for extension over facet... both can work
for me.

On Wed, May 21, 2014 at 4:18 PM, Angelo [email protected] wrote:

you called it "Tern >Extensions"?

I prefer using "Facet" instead of using "Extension", because Eclipse user
are famliliar with "Facet" (you add some capabilities to your project). But
if you prefer "Extension", I will change it.

I'm somehow surprised to see that there is no "JavaScript" top category.

"JavaScript" top category is ecma5 JSON Type Definition, I would like to
avoidd changing the original name.

Tern and Angular could fit in.

Tern is the inference Javascript engine which is configured with plugins,
JSON Type Definition. AngularJS Eclipse is based on the Tern plugin angular.

Don't you depend on JSDT ?
Yes and no:)

Tern IDE UI doesn't depends on JSDT. So you could use tern.java for
other editor kind.

The project
https://github.com/angelozerr/tern.java/tree/master/eclipse/tern.eclipse.ide.jsdtis a bridge between Tern and JSDT : it defines for instance compeltion
extension for JSDT with tern.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-43726305
.

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com

from tern.java.

Ok thank's @gamerson I will keep "Facets" for the moment.

Just for your information, I have the intention to improve this UI with:

• add version column which will work only for some tern plugin (like AUI/YUI, DojoToolkit). See #67
• add a ShahForm like "Project Facets" to customize some tern plugin. See #64

from tern.java.

I agree with @gamerson i think facet is a very different thing than this.

This is something you would configure on a tern/javascript facet - it is not a facet itself.

from tern.java.

Ok @maxandersen, we could rename facet to

• modules?
• add-ons?
• other?

I would like to avoid using "plugin" because tern provides Tern plugin and JSON Type Definition.

My preference is module. I'm waiting for your answer.

from tern.java.

@vrubezhny @dgolovin @mickaelistria @maxandersen @pascalleclercq @gamerson @paulvi are you OK to rename facet to module?

from tern.java.

Personally me - yes, I'm OK with 'module' instead of 'facet'.

from tern.java.

Ok I have created a new issue for that. See #81 I will try to do that this WE. If you don't like 'module', please tell me.

from tern.java.

Ok changes was done (screenshot of wiki too). Now module is used instead of facet.

from tern.java.