Giter Club home page Giter Club logo

Comments (2)

AngelMunoz avatar AngelMunoz commented on August 27, 2024

This is an interesting situation, I'll try to reproduce later on I did test often in postgresql so it hits me in a weird way.

I'd have a few more questions in regards to this

  • does this happen with any particular schema
  • did it happen with an schema that contains "migration" as a table as well?

I ask this because the error looks as if there's something trying to add to the migration table

relation "migration" already exists

the key word here being relation I haven't seen that kind of error message before

There seems to be handling for situations when table already exists for SQLite databases, but how about other database types?

We cover each database individually
in Queries.fs:145 we have the createMigrationsTable function that calls createTableQuery

let private createTableQuery driver =
    match driver with
    | Driver.Sqlite ->
        """
        CREATE TABLE migration(
            id INTEGER PRIMARY KEY AUTOINCREMENT,
            name VARCHAR(255) NOT NULL,
            timestamp BIGINT NOT NULL
        );
        """
    | Driver.Postgresql ->
        """
        CREATE TABLE migration(
            id SERIAL PRIMARY KEY,
            name VARCHAR(255) NOT NULL,
            timestamp BIGINT NOT NULL
        );
        """
    | Driver.Mysql ->
        """
        CREATE TABLE migration(
            id INT AUTO_INCREMENT PRIMARY KEY,
            name VARCHAR(255) NOT NULL,
            timestamp BIGINT NOT NULL
        );
        """
    | Driver.Mssql ->
        """
        CREATE TABLE dbo.migration(
            id INT PRIMARY KEY,
            name VARCHAR(255) NOT NULL,
            timestamp BIGINT NOT NULL
        );
        """

I guess I could modify those to include a if not exists clause and even maybe use a not so common name __migondi__migrations or something like that

In any case I'll report back thanks for raising the issue

from migrondi.

AngelMunoz avatar AngelMunoz commented on August 27, 2024

This has been fixed in v0.7.1 and is being indexed by nuget, I'll publish a GH release soon as well, feel free to re-open if for some reason it doesn't work

from migrondi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.