Comments (6)
I understand that eslint handles a whole class of things that prettier does not, but I kind of like to talk about those things during code review anyway.
That is true for code style, but the important "whole class of things that prettier does not handle" is stuff like checking for unused variables, broken references, etc. That's what prettier cannot provide. I say it should not be the reviewer's responsibility either, since it can be reliably checked by software 😉
from webpack-blocks.
Could you please link to those places with different code styles?
Using prettier has been a topic for quite some time. I don't see any reason against, there was just no time yet to do that.
How would the Airbnb ruleset change anything? Because it's stricter?
from webpack-blocks.
Using prettier has been a topic for quite some time. I don't see any reason against, there was just no time yet to do that.
Setting up Prettier and ESLint is really easy, I've even created an ESLint preset that automatically configures Prettier and the Airbnb preset.
How would the Airbnb ruleset change anything? Because it's stricter?
No. It's just my preference.
from webpack-blocks.
I prefer husky + prettier and no eslint. I understand that eslint handles a whole class of things that prettier does not, but I kind of like to talk about those things during code review anyway.
from webpack-blocks.
Is this issue still relevant, now that we have prettier in the v2.0 branch?
from webpack-blocks.
We've got both Prettier and ESLint. Now we can add more ESLint rules over time.
from webpack-blocks.
Related Issues (20)
- Have setOutput accept an object HOT 1
- Add tsd HOT 7
- createConfig from available webpack base config HOT 6
- Allow negations in match HOT 8
- Support for webpack 4 HOT 34
- @webpack-blocks/babel-loader: how to disable exclude node_modules HOT 12
- 2.0 roadmap HOT 26
- Move unpopular blocks to the webpack-blocks org HOT 11
- uglify package 1.0.0 doesn't match what is in the npm registry HOT 3
- Using assets package with webpack 4 and babel7 HOT 1
- Webpack blocks for webpack ^4.0.0 and babel ^7.0.0 HOT 2
- How to create custom block with new version? HOT 1
- Update typescript block to work with webpack 4 HOT 4
- Ability to extend options passed to include configFile HOT 3
- Tag a new version for update peer dependencies commit HOT 1
- devserver: hot and HotModuleReplacementPlugin
- Outdated PostCSS README HOT 1
- Cannot see how to remove or filter out HotModuleReplacementPlugin
- webpack-blocks/* issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webpack-blocks.