Just use iconv-lite? about encoding HOT 7 CLOSED

Currently not. node-iconv handles transliteration and has a broader support for different charsets. But in the future, when iconv-lite catches up, then yes. Right now, iconv-lite is just a fallback for the systems where node-iconv has compiling issues and node-iconv is preferred.

from encoding.

Perhaps time to take another look at this?

from encoding.

node-iconv is not a required dependency anymore and iconv-lite is used by default. node-iconv is only used if it is installed separately.

from encoding.

Ah, gotcha. Browserify still breaks when building encoding because it detects the iconv dep, but this can be fixed by the user by passing iconv to Browserify's ignore. So probably not worth fixing here.

from encoding.

Though, I believe the fix would be as easy as:

try {
    var iconv_package = 'iconv';  // this is to fool browserify so it doesn't try (in vain) to install it. 
    Iconv = require(iconv_package).Iconv;
} catch (E) {
    // node-iconv not present
}

Would be happy to submit a PR if you like.

from encoding.

I don't really care about browserify compatibility but haven't got anything against it, so if you'd create a PR that doesn't break anything existing and works with browserify I'd pull it.

from encoding.

Great, submitted. Let me know if that's okay

from encoding.