Giter Club home page Giter Club logo

Comments (4)

achubaty avatar achubaty commented on July 19, 2024

What's your preference for specifying Rversion? Note that all three mechanisms will work with the functions. The default is to use the current system version, but this can be overridden by the user.

  1. using R.version and extracting the list elements major and minor. If specifying for a non-system version, user can use Rversion=list(major="3", minor="1.0")
  2. "proper" numeric version using getRversion(). If specifying for a non-system version, user can use Rversion=R_system_version("3.1.0"). I prefer this because comparing numeric versions is built in.
  3. supplying character string 3.1.2. This is obviously easiest for user to specify non-system version: Rversion="3.1.0".

from minicran.

andrie avatar andrie commented on July 19, 2024

I agree with your analysis. I don't have a strong preference, other than:

  • We are consistent in the defaults for all functions
  • It's easy for the user (and I agree specifying a list isn't easy)

In fact we only need the major and minor version number, e.g. "3.1".

I'll think more about this tomorrow.

from minicran.

achubaty avatar achubaty commented on July 19, 2024

Option 3 above is the easiest for the user, so I've gone ahead with that. We can convert to to an R_system_version under the hood to make version string comparisons.

Note that I'm only making the changes to the documentation -- the functions using Rversion (namely, twodigitRversion) will still work if specified using the other approaches.

See the 42-rversion branch, which was branched from master this morning.

from minicran.

andrie avatar andrie commented on July 19, 2024

I merged this branch 24-addPackages into dev

from minicran.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.