Incorrect diff reported between identical arrays of mixed strings and objects about json-diff HOT 4 CLOSED

On Mon, Mar 7, 2022 at 8:31 PM Sean Anastasi ***@***.***> wrote: I think I've identified what the problem is. This <luckygerbils@b5c0110> is a hacky fix/workaround, but probably not the right solution. The issue is that, when scalarizing the first array, the original index of each object in the array is tracked only incidentally via the object entry position in fuzzyOriginals <https://github.com/andreyvit/json-diff/blob/master/lib/index.js#L69>. But since the initial "a" element is a scalar already, it isn't put into fuzzyOriginals and therefore the entry position of every subsequent object vs it's actual original index is off by one. My hacky fix just adds a placeholder for any actual scalar values to fuzzyOriginals so that the indexes match up. This appears to fix the issue, at least in the test case I added. This doesn't feel like the best solution though. It seems like it would be better to explicitly remember the original index of each scalarized value by storing something like originals[key] = { item, index } instead of originals[key] = item. This requires changes to the descalarizing code though, which I haven't looked at yet. I can do that and send a pull request if my interpretation of this issue sounds correct to you. — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6OIPOLDOQ76RJZ2456LPDU62UYFANCNFSM5QEYV5BA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>