Screenshot crash about wyrmgus HOT 8 CLOSED

Thanks reporting this issue; unfortunately I am not able to reproduce it.

SysReq also takes a screenshot, so the issue is likely with the Screenshot() function itself (or the SaveScreenshotPNG() function it calls).

Does this crash happen both when you are playing with OpenGL rendering enabled, and when it is disabled?

from wyrmgus.

The crash only happens with OpenGL rendering enabled. As it turns out, it was taking screenshots, but I was expecting to find them in my Pictures folder where screenshots normally go. I hadn't thought to look in ~/Wyrmgus. The ones that resulted in crashes turned out rather oddly, while the ones with OpenGL disabled turned out fine.

Odd result:

from wyrmgus.

Thanks, that's helpful :)

So the issue is likely in the following piece of code in SaveScreenshotPNG() (in \video\png.cpp):

#if defined(USE_OPENGL) || defined(USE_GLES)
    if (UseOpenGL) {
        std::vector<unsigned char> pixels;
        pixels.resize(Video.Width * Video.Height * 3);
#ifdef USE_OPENGL
        glReadBuffer(GL_FRONT);
#endif
        glReadPixels(0, 0, Video.Width, Video.Height, GL_RGB, GL_UNSIGNED_BYTE, &pixels[0]);
        for (int i = 0; i < Video.Height; ++i) {
            png_write_row(png_ptr, &pixels[(Video.Height - 1 - i) * Video.Width * 3]);
        }
    } else
#endif

from wyrmgus.

timfel has made an update to fix this issue, which I've implemented into Wyrmgus here:
f271eb5

Does it fix the problem for you?

from wyrmgus.

The game no longer crashes upon taking a screenshot most of the time, but the screenshot is still gray and distorted as before (or a corrupted file), and the game freezes upon trying to exit if I previously took a screenshot during that session. It still sometimes causes the game to freeze, which seems to occur more when I've switched from windowed to fullscreen. I also still managed to crash it once by just taking a screenshot in the opening menu (output below). As before, everything is fine with OpenGL disabled.

*** Error in `./stratagus': double free or corruption (out): 0x0000000015b59460 ***
./launch: line 1: 31990 Aborted                 ./stratagus -d ~/Wyrmsun/ -u ~/Wyrmsun/

In this case ./launch refers to ./stratagus -d ~/Wyrmsun/ -u ~/Wyrmsun/, the script I use to launch the game.

from wyrmgus.

Unfortunate that it didn't fix the problem, but at least there was some improvement. There was a further update from upstream on this issue which I've implemented into Wyrmgus, maybe it will help:
a645c96

from wyrmgus.

That doesn't seem to have made any difference.

from wyrmgus.

This should be fixed now with the following commit:
9514a22

from wyrmgus.