I'm updating Mageia's wyrmsun package to the current 1.9.5 release, and I have this bu

I've submitted a fix: <a class="commit-link" data-hovercard-type="commit" data-hov

format-security issues in src/map/map.cpp about wyrmgus HOT 7 CLOSED

akien-mga commented on August 19, 2024

format-security issues in src/map/map.cpp

from wyrmgus.

Comments (7)

Andrettin commented on August 19, 2024

I've submitted a fix:
49e5b8f

Could you let me know whether it worked?

from wyrmgus.

akien-mga commented on August 19, 2024

The changes look good, I'll test them in the evening.

from wyrmgus.

akien-mga commented on August 19, 2024

That worked! Now I get another format-security error further down:

[  5%] Building CXX object CMakeFiles/stratagus.dir/src/stratagus/player.cpp.o
/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-master/src/stratagus/player.cpp: In function 'void PlayersEachCycle()':
/home/akien/Mageia/Checkout/wyrmsun/BUILD/Wyrmgus-master/src/stratagus/player.cpp:1772:59: error: format not a string literal and no format arguments [-Werror=format-security]
      Players[j].Notify(_("Your units have been revealed!"));
                                                           ^

from wyrmgus.

akien-mga commented on August 19, 2024

A few more further down the road, I'll make a PR

from wyrmgus.

Andrettin commented on August 19, 2024

I'm uploading a fix as we speak, and I fixed two more in unit.cpp as well :)

from wyrmgus.

akien-mga commented on August 19, 2024

Alright, that's the ones I was about to push too :p

from wyrmgus.

Andrettin commented on August 19, 2024

Fixed