Giter Club home page Giter Club logo

Comments (5)

andres-montanez avatar andres-montanez commented on September 28, 2024

Hi, I've just tried this

<?php
namespace Mage\Task\BuiltIn\Ioncube;

use Mage\Task\AbstractTask;

class EncryptTask extends AbstractTask
{
    public function getName() {
        return 'Encrypt';
    }

    public function run() {
        return true;
    }
}

and it worked ok.
Is the yaml indentation ok?

It must be

tasks:
  pre-deploy:
    - ioncube/encrypt

Let me know, it looks like an interesting task to add to the core :)

from magallanes.

marl-scot avatar marl-scot commented on September 28, 2024

Hi,

It was the yaml syntax, had used tab on one line and spaces on another,
Any chance of adding a syntax checker?

Once I have the module completed will let you have a look at it.

thanks

M

from magallanes.

andres-montanez avatar andres-montanez commented on September 28, 2024

Good.
I will look if the yaml parser library has a syntax validator.

from magallanes.

marl-scot avatar marl-scot commented on September 28, 2024

Hi Andres,
Even if the yaml parser outputs a error code to say something went wrong with the parsing, and that was echoed to the end user.
M

from magallanes.

andres-montanez avatar andres-montanez commented on September 28, 2024

Changed the YAML parser (now uses the Symfony YAML Component), so if the yaml is badly formatted, then exceptions will be thrown.

from magallanes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.