Giter Club home page Giter Club logo

Comments (7)

andreas-kupries avatar andreas-kupries commented on August 24, 2024

Looking over the code the targetplatform information likely comes from the buildplatform information, which is initialized to the result of platform::generic.
This is the reduced platform information which has things like OS differences removed.
The full identification requires platform::identify.

Notes:

  1. The platform package is part of the Tcl core distribution. Definitely in 8.6+. Cannot recall when in the 8.5.x series, i.e. which patchlevel, it was added. Easiest to check is to run package require platform and see if that returns an error or not.
  2. As an aside, critcl comes with a critcl::platform package for when Tcl does not provide it (8.4.x for example).
  3. I do not recall what the output of platform::identify would be for FreeBSD.
    I suspect it does not take the FreeBSD differences into account there yet (because we had no FreeBSD machines around when it was written).
    It does account for Solaris kernel differences, and Linux glibc version differences..
  4. I would recommend to run platform::identify on your machines. Please provide patches to the Tcl core if the data coming back from the command is wrong.

from critcl.

andreas-kupries avatar andreas-kupries commented on August 24, 2024

Mostly addressed in commit 22cb4f3.
I still need information about the output of platform::identify on "FreeBSD" to say if that needs an update or not.

from critcl.

andreas-kupries avatar andreas-kupries commented on August 24, 2024

Closing. Aforementioned commit has the switch generic to identify.
The info about FreeBSD has to go through the core's platform package.
The relevant tracker is at https://core.tcl.tk/tcl/tktnew

from critcl.

UnitedMarsupials-zz avatar UnitedMarsupials-zz commented on August 24, 2024
% package require critcl
3.1.15
% package require critcl::platform
1.0.11
% platform::identify
freebsd-amd64

Back in 2006 I created an account (aku) for you on one of my machines. The account is still active -- you are most welcome to use it for testing any of your software on FreeBSD.

from critcl.

andreas-kupries avatar andreas-kupries commented on August 24, 2024

Huh. Can you give me the name/IP of that machine ?
Do I need a password as well ?

from critcl.

andreas-kupries avatar andreas-kupries commented on August 24, 2024

Ok. This issue should now be fully addressed, with commits 136cab3 and 4152c8e.

The internal package critcl::platform now incorporates the FreeBSD ABI version, and this package is preferred while the official package in the core does not do the same.

Note, while I tested on your machine, I had to make some local changes to ensure that my test code used the new critcl::platform package (@/home/aku/opt) instead of the older one from the global critcl installation (@/opt). As such I would like to ask you to do your own check as well, with a properly installed critcl, and your own examples.

from critcl.

andreas-kupries avatar andreas-kupries commented on August 24, 2024

Nothing bad heard for two weeks, considering this as done.

from critcl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.