Regression bug - Empty response from console MARS server about mars HOT 13 CLOSED

@andrea-magni ... maybe it's good idea to close this task too, because bug is fixed. If you want I can copy our discussion about Continuous Integration to new issue. You should mark those issues with [discussion] tag and with [help wanted]

from mars.

@andrea-magni about the labels - nice article: norgepaul/TChromeTabs#69

New labels:

• discussion #CA1F7C
  • the color is the same like question label
• good first issue #6E46FF
  • something easier then help wanted and help wanted is more convenient for the discussion issue, for the documentation both are very useful, for the bugs - help wanted or discussion if you want to discuss things, for new features discussion is the best
• on hold #D2DAE1
  • very important to show to the community that you are aware about the problem it you have to move to the task (bug / feature) for later
• invalid #D2DAE1
  • out of the project scope
• feature #93CE55
  • I like this more then the enhancement label, because it's more precise

from mars.

You are missing a uses: MARS.Core.MessageBodyWriters.
Adding the uses will register MessageBodyWriters (in your application there are none so the request actually succeed but the result value is not serialized to the response).
I am going to add an exception to handle this case. If the method is a function (and not a procedure) and no serializers are available, you think you should get an error.

As an aside, I have seen more than once that you are using a browser (and referring to REST methods as web pages). This is something I generally discourage and I tend to suggest using a REST debugger instead (Embarcadero's one or Postman, but there are many). There is so much more control on the request and on its conten, you can easily replay request and you can get some insights you would not be able to see with a browser (even if Chrome Dev Tools are great).

from mars.

Now you get a 500 Internal Server Error with this body as error message:
MessageBodyWriter not found for method SayHelloWorld of resource THelloWorldResource

Thanks for spotting this :-)

from mars.

About testing: MARS currently has some unit tests (see https://github.com/andrea-magni/MARS/tree/master/tests ) and I am quite interested in building a set of integration tests and setup an automated system. I do have a Linux machine in the cloud so I can try to setup a webhook for git commits having that machine pull the repo, build the test project, execute and report results.
Will think about this.

from mars.

Yeep! It wasn't a regression bug, but last week this sample was working even without MARS.Core.MessageBodyWriters, because of that I was thinking that is a regression. After adding MBW now everything is fine.

Idea of rising an expression is great and for sure will be very helpful for newcomers. I can verify this after you will commit my master with PR #39. I've got an idea how to organize better with things like registration of [Message Body Writer] or [JSON Token], which are rather internal, but have to rethink that more. When I will be sure then I register new issue for that.

from mars.

I have seen more than once that you are using a browser (and referring to REST methods as web pages). This is something I generally discourage and I tend to suggest using a REST debugger instead (Embarcadero's one or Postman, but there are many).

I know Postman and was using this a lot, even CURL is OK for me. Now I switched to VS Code and its great extension https://github.com/Huachao/vscode-restclient/ which is amazing for me. Despite this I'm trying to work as a common Delphi programmer which is more used to Web Browser then to other more convenient tools. This effect "easy of use" for newcomers is very important in my opinion.

from mars.

I am quite interested in building a set of integration tests and setup an automated system. I do have a Linux machine in the cloud

I'm quite interested too ... then there are two of us, but I'm more then sure then you will require Windows cloud host, because of the compiler. For the continuous integration you will need to:

• fetch commit with git (Linux is fine for that)
• compile source code (Win machine is required)
• report any compilation errors
• run compiled DUnitX app/apps (probably Linux is fine for that, but I'm not sure)
• report integration tests log

from mars.

Oh well, yes, I didn't think twice about compiler. Of course we need a Windows machine somewhere.
I used to have a Windows VPS but then switched to a Linux box. Will consider using a spare Windows machine of mine. Where one would report errors? I can think about having a Slack channel or publishing data somewhere on the web... other ideas?

from mars.

There is better solution. It requires some tricks to cover, but I was using it before with JavaScript GitHub project when I was contributing in it. The answer is Jenkins. It works almost magically. When anyone adding a new commit to the Pull Request then GitHub via webhook notifies Jenkins, installed somewhere in the cloud, that it's time to work and GitHub is waiting for the Jenklns response to accept this commit. Of course Jenkins is doing hard work.

Some interesting articles for that:

• https://www.valuebound.com/resources/blog/continuous-integration-using-jenkins-and-github-to-automate-deployment
• https://www.blazemeter.com/blog/how-to-install-jenkins-on-windows

I can get on my own to test and configure everything, but not in the November.

from mars.

To be more Delphi way you can as VSoft team about integration with GitHub
https://www.finalbuilder.com/continua-ci
I'm sure that is possible and maybe they've got access to GitHub webhook.

from mars.

I found something interesting for Linux box, but it's extremely tricky: docker container with Windows Server Core and inside manually copied Delphi Compiler:

• https://hub.docker.com/r/microsoft/windowsservercore/
• http://delphi.wikia.com/wiki/Setting_up_a_Delphi_Build_Machine

However, there are no guarantees or confirmation that such a thing may work. Maybe Marco knows something about that :-)

from mars.

Done, I also added the "in progress" one, yellow.

from mars.