Giter Club home page Giter Club logo

Comments (4)

AndGem avatar AndGem commented on May 29, 2024

Hi @EricRossC

Thanks a lot for the this proposal. It looks good to me, the only thing I was thinking about is people may have different use cases where indoor may be not desirable to have in the network.

Not sure what the best approach is, but I'll think about it a bit more, and see what I can do.

But really awesome to hear this project is being used.

If you are interested, I'm currently working on a re-implementation in Rust that is able to handle the binary OSM files and is significantly faster. You can find it here: https://github.com/AndGem/OsmToRoadGraphRust but it's not even with respect to functionality.

Anyway, I'll keep you updated. If you have more proposal, feel free to add them.

from osmtoroadgraph.

AndGem avatar AndGem commented on May 29, 2024

@EricRossC

Actually, everything looks good to me, since the configuration of the considered highway tags is defined somewhere else. Do you want to open a PR or are you ok with me merging you changes directly by myself?

Thanks again.

from osmtoroadgraph.

AndGem avatar AndGem commented on May 29, 2024

@EricRossC just fyi, I added a change to enable indoor path extraction, but a bit different that in your proposal. I also added an explanation in the README to show how it would work. Please let me know if you have concerns or other proposals.

Thanks again!

from osmtoroadgraph.

EricRossC avatar EricRossC commented on May 29, 2024

Thanks!

from osmtoroadgraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.