FindNextSibling bug about soup HOT 4 CLOSED

Fixed it in the above commit, and renamed them to FindNextElementSibling() and FindPrevElementSibling()
I'll be implementing the actual FindNextSibling() and FindPrevSibling() in the upcoming commits.

from soup.

Thanks for reporting it. I'll try to fix it as soon as possible.

from soup.

I think the fix d325696 does not work because it is r.Pointer.NextSibling might be nil, and calling .NextSibling on it causing the nil pointer dereference crash/panic.

Maybe try this:

func (r Root) FindNextSibling() Node {
	nextSibling := r.Pointer.NextSibling
	if nextSibling == nil {
		log.Fatal("No next sibling found")
	}
	// try to find next element-node?
	if nextSibling.Type == html.ElementNode {
	       return Root{nextSibling}
	} else {
	       // keep looking
	}
}

from soup.

Ah, I see it now. I'll make the fixes accordingly.

from soup.