Globbing multiple files about node-sass-import HOT 6 CLOSED

Hey @rstacruz do you have a use case I can take a look at?

from node-sass-import.

Yep! http://rscss.io

On Fri, Sep 30, 2016, 7:43 AM Emmanuel Addo Narh [email protected]
wrote:

Hey @rstacruz https://github.com/rstacruz do you have a use case I can
take a look at?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikdNRnQzQcVECKk6MqjHFqkeTBYHQks5qvE0agaJpZM4JvYIo
.

from node-sass-import.

@rstacruz very nice work on rscss!! I'm going to try and add this feature.

from node-sass-import.

Hey @rstacruz,
So after trying a few scenarios, it appears the easier route might be using some entry file (index.scss) to import/list all the necessary files needed vs. going the glob (/) route. The reason behind this is because I'm using the resolve module to lookup files in both the npm & local filesystems. That resolve module unfortunately does not take raw globs for lookups for now. Adding that feature would require prior knowledge through the '@import url' as to whether the '@import url' (e.g. @import somecss/) is referring to a local lookup or an npm(node_modules) lookup. I didn't want to add some form of symbols (e.g. ~) to indicate that it's an npm module because that approach is an anti-pattern approach. And because I wanted to stay true to the npm patterns (require), I offloaded the lookup to the "resolve" module to do the dirty work of figuring out the location of the '@imported' files regardless of where they may be located just like with javascript "require".

Let me know if you have some thoughts or suggestions around getting your proposal to work while still maintaining the patterns. In most of my work, I always use an entry file that lists all the files individually. I also see most folks and libraries doing the same. But I do recognize the appeal to not having to list all the files by hand if you don't have to.

from node-sass-import.

Hm, lemme think about it and try to hack around it.

On Mon, Oct 3, 2016, 9:45 AM Emmanuel Addo Narh [email protected]
wrote:

Hey @rstacruz https://github.com/rstacruz,
So after trying a few scenarios, it appears the easier route might be
using some entry file (index.scss) to import/list all the necessary files
needed vs. going the glob (/) route. The reason behind this is
because I'm using the resolve module to lookup files in both the npm &
local filesystems. That resolve module unfortunately does not take raw
globs for lookups for now. Adding that feature would require prior
knowledge through the '@import https://github.com/import url' as to
whether the '@import https://github.com/import url' (e.g. @import
https://github.com/import somecss/) is referring to a local lookup or
an npm(node_modules) lookup. I didn't want to add some form of symbols
(e.g. ~) to indicate that it's an npm module because that approach is an
anti-pattern approach. And because I wanted to stay true to the npm
patterns (require), I offloaded the lookup to the "resolve" module to do
the dirty work of figuring out the location of the '@imported
https://github.com/imported' files regardless of where they may be
located just like with javascript "require".

Let me know if you have some thoughts or suggestions around getting your
proposal to work while still maintaining the patterns. In most of my work,
I always use an entry file that lists all the files individually. I also
see most folks and libraries doing the same. But I do recognize the appeal
to not having to list all the files by hand if you don't have to.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikXpCkesbjVTDvNyT5m5usZzkR5j-ks5qwF45gaJpZM4JvYIo
.

from node-sass-import.

I don't think there needs to be a special symbol or anything. All that needs in the module's logic is to do something different if it matches more than 1:

// pseudo-code

files = glob('components/*')
if (files.length === 1) {
  return { file: files[0] } /* eg, 'components/button' */
} else {
  return { contents: '@import "components/button"; @import "components/form";' }
}

Looking at the code, this isn't so simple because you need to do async.parallel among the resolver() calls, so there's some internal API rearranging that needs to happen, but it's possible :)

from node-sass-import.