Threading bug found, this our fix. about czml-writer HOT 4 CLOSED

Your fix may just be hiding a bigger threading problem. Instances of CachingCesiumUrlResolver are definitely not thread-safe, and cannot be used across threads. Instead, each thread should obtain its own instance, using CachingCesiumUrlResolver.getThreadLocalInstance().

Can you provide more detail about the exception you're getting?

from czml-writer.

Hey Scott,

Yeah I guess a fix was the wrong word to use. I can't provide the
exception until I get to work tomorrow. But what I can say is that
getThreadLocalInstance() is never called. I noticed that method was there,
but I wasn't sure if we were supposed to call that directly or not. As all
we do is repeatedly call writeImage when we are writing out our billboards.
I'll provide the stack trace tomorrow.

-Jon

On Mon, Jun 24, 2013 at 5:15 PM, Scott Hunter [email protected]:

Your fix may just be hiding a bigger threading problem. Instances of
CachingCesiumUrlResolver are definitely not thread-safe, and cannot be
used across threads. Instead, each thread should obtain its own instance,
using CachingCesiumUrlResolver.getThreadLocalInstance().

Can you provide more detail about the exception you're getting?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-19936439
.

from czml-writer.

@shunter Can this be closed?

from czml-writer.

I think so, yes. CachingCesiumUrlResolver is not intended for use from multiple simultaneous threads.

from czml-writer.