Self closing tags about html-object HOT 8 CLOSED

Do you have an example of code that doesn't work so that I can write a test for it, to make sure the bug doesn't come back ?

from html-object.

I used this code:

// Add input
$inputCsrfName = Input::hidden("csrfName", $this->_csrfName);
echo $inputCsrfName;

from html-object.

That outputs the correct HTML for me :

$input = Input::hidden('csrf', 'foobar');

var_dump($input->render());
// string(48) "<input type="hidden" name="csrf" value="foobar">"

What do you get ?

from html-object.

Yeah, that's what I get too, but it should have a closing / at the end:

<input type="hidden" name="csrf" value="foobar" />

from html-object.

Well if it's HTML5 and not xHTML then no, it shouldn't.

from html-object.

Ah, I guess you're right. I've been using them in HTML5 as well, even though they're no longer mandatory...

Maybe a static configuration variable might be useful then, so it can work both ways? Like

public static $useSelfClosingSlash = false;

from html-object.

Hm that could be done I guess, will work on it.

from html-object.

Cool. I'm a bit new to Github, but I'll try to fork the project and add it there, so you can see if you like the fix.

from html-object.