Comments (8)
anacrolix
commented on May 29, 2024
1
I am disappointed that Ian Lance Taylor is curmudgeonly about so many changes but is happy to break this needlessly.
I have switched to a genericized version of the standard library heap instead.
from torrent.
AskAlexSharov
commented on May 29, 2024
@anacrolix hi. seems this commit - introduced some deadlock. CI is red https://github.com/anacrolix/torrent/actions/runs/5877936323/job/15939030611 and my app can't shutdown on ctrl+c
not sure - if it's related, i see next trace:
1: 6144 [1: 6144] @ 0x1007e0646 0x100091379 0x1007e3e8e 0x1007e3e74 0x1007e378e 0x1007e181c 0x1007df7ed 0x1007df78a 0x1007e014a 0x1009988b4 0x10099a726 0x10099aa87 0x1009a1518 0x100974dd0 0x100974cb4 0x10152b6bc 0x10152a139 0x101527132 0x1005b12e4 0x1000735a1
# 0x1007e0645 github.com/ajwerner/btree/internal/abstract.getNodePool[...].func1+0x25 github.com/ajwerner/[email protected]/internal/abstract/node_pool.go:39
# 0x100091378 sync.(*Pool).Get+0xb8 sync/pool.go:151
# 0x1007e3e8d github.com/ajwerner/btree/internal/abstract.(*nodePool[...]).getLeafNode+0x10d github.com/ajwerner/[email protected]/internal/abstract/node_pool.go:59
# 0x1007e3e73 github.com/ajwerner/btree/internal/abstract.(*Node[...]).split+0xf3 github.com/ajwerner/[email protected]/internal/abstract/node.go:287
# 0x1007e378d github.com/ajwerner/btree/internal/abstract.(*Node[...]).insert+0x1ad github.com/ajwerner/[email protected]/internal/abstract/node.go:357
# 0x1007e181b github.com/ajwerner/btree/internal/abstract.(*Map[...]).Upsert+0x2fb github.com/ajwerner/[email protected]/internal/abstract/aug_btree.go:127
# 0x1007df7ec github.com/ajwerner/btree.(*Set[...]).Upsert+0x8c github.com/ajwerner/[email protected]/btree.go:52
# 0x1007df789 github.com/anacrolix/torrent/request-strategy.(*ajwernerBtree).Add+0x29 github.com/anacrolix/[email protected]/request-strategy/ajwerner-btree.go:32
# 0x1007e0149 github.com/anacrolix/torrent/request-strategy.(*PieceRequestOrder).Add+0xc9 github.com/anacrolix/[email protected]/request-strategy/piece-request-order.go:47
# 0x1009988b3 github.com/anacrolix/torrent.(*Torrent).addRequestOrderPiece+0xf3 github.com/anacrolix/[email protected]/torrent-piece-request-order.go:58
# 0x10099a725 github.com/anacrolix/torrent.(*Torrent).onSetInfo+0x1a5 github.com/anacrolix/[email protected]/torrent.go:485
# 0x10099aa86 github.com/anacrolix/torrent.(*Torrent).setInfoBytesLocked+0x1a6 github.com/anacrolix/[email protected]/torrent.go:520
# 0x1009a1517 github.com/anacrolix/torrent.(*Torrent).SetInfoBytes+0x97 github.com/anacrolix/[email protected]/torrent.go:1531
# 0x100974dcf github.com/anacrolix/torrent.(*Torrent).MergeSpec+0x8f github.com/anacrolix/[email protected]/client.go:1414
# 0x100974cb3 github.com/anacrolix/torrent.(*Client).AddTorrentSpec+0x133 github.com/anacrolix/[email protected]/client.go:1399
from torrent.
anacrolix
commented on May 29, 2024
I think the CI tests are just a bit flakey. I'm not sure this commit introduced the issue. I could be wrong.
from torrent.
AskAlexSharov
commented on May 29, 2024
Seems I did mistake when tested rollback to prev version. Seems my app stuck on prev version also. Then ball on my side for now.
from torrent.
anacrolix
commented on May 29, 2024
I've pushed https://github.com/anacrolix/torrent/compare/generic-heap-ci-revert?expand=1 to test your theory, but I'm pretty sure it's just flakey tests. Thanks for following up.
from torrent.
AskAlexSharov
commented on May 29, 2024
seems i fixed my app shutdown issue. not related to the torrent lib. thank you.
from torrent.
anacrolix
commented on May 29, 2024
There is an significant issue caused by the heap change. I'm investigating.
from torrent.
anacrolix
commented on May 29, 2024
There was serious behaviour bug fixed in 87f6cdc.
from torrent.
Related Issues (20)
- Cannot `go get` this library HOT 3
- Inferring reasons for stopped transfer? HOT 3
- Race from peerconn on data read of closed torrent with [email protected] HOT 4
- Clean up ClientConfig HTTP options HOT 3
- error bootstrapping during bucket refresh: getting starting nodes: nothing resolved [dht 0.0.0.0:42069 github.com/anacrolix/dht/v2 server.go:1395] HOT 7
- Webseed download extremely slow HOT 1
- Count the number of bytes uploaded or downloaded. HOT 6
- Peer Selection Algorithm
- undefined: sync.OnceFunc HOT 7
- Support passing context to `torrent.Reader` HOT 1
- How to config DHT listen port? HOT 4
- Add global semaphore to limit amount of pieceHashers
- Problem getting magnet metadata on large files HOT 6
- Client requests indefinitely on storage write errors HOT 42
- More than 3 times slow download speed over sqllite storage HOT 9
- Prioritize the use of local peers HOT 1
- Slow downloads while multiple large torrents are being downloaded. HOT 25
- panic: net/http: internal error: connCount underflow HOT 9
- listen tcp6 :42069: socket: address family not supported by protocol HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from torrent.