Giter Club home page Giter Club logo

Comments (8)

amtrack avatar amtrack commented on June 11, 2024 1

@ozanbotanls I'm now able to reproduce this given your description of the combination of those two feature enablements.

from sfdx-browserforce-plugin.

ozanbotanls avatar ozanbotanls commented on June 11, 2024

Could it be related to here?
https://github.com/amtrack/sfdx-browserforce-plugin/blob/master/src/plugins/salesforce-to-salesforce/index.ts#L46

As this feature in the setup is only available in Classic mode, on the layout there are 2 input save buttons (one at the header and one at the footer) Could it be failing due to this clash?

from sfdx-browserforce-plugin.

amtrack avatar amtrack commented on June 11, 2024

@ozanbotanls Thanks for the report and your hint!
I'll look into this in the next few days.

In the meanwhile you could try to run it locally in the headful mode (environment variable: BROWSER_DEBUG=true). Maybe you can spot the problem quickly.

from sfdx-browserforce-plugin.

amtrack avatar amtrack commented on June 11, 2024

@ozanbotanls I wasn't able to reproduce this.
The E2E tests are passing in CI and when running this locally, the feature got enabled in my scratch org and I can query the PartnerNetworkRecordConnection object (SELECT Id FROM PartnerNetworkRecordConnection) without any error.

I'm looking forward to your results from running it locally in headful mode as described in my comment above.

from sfdx-browserforce-plugin.

ozanbotanls avatar ozanbotanls commented on June 11, 2024

Hey @amtrack

Thanks for looking into it. First things first: the aforementioned problem doesn't occur all the time but started to happen now more than it used to do.

Secondly, I tried with headful mode with a brand new scratch that I created. The browser automation opened up the SF to SF page and then was even able to select "enable" checkbox, then it closed up the page. I assumed it also "saved" the form. But when I manually went to check the feature after the automation is done, no it was not the case. The feature was still inactive.

So, I'm suspicious about "clicking on the save button". There might be some inconsistent situation around this.

from sfdx-browserforce-plugin.

amtrack avatar amtrack commented on June 11, 2024

@ozanbotanls Unfortunately I still cannot reproduce this.
About the two save buttons, I checked the docs of Puppeteer:

If there are multiple elements satisfying the selector, the first will be clicked.

If you have any more hints about how to reproduce this issue, please let me know.

from sfdx-browserforce-plugin.

ozanbotanls avatar ozanbotanls commented on June 11, 2024

@amtrack Thanks a lot for surfacing this!

My configuration file was holding both HVS and SF to SF enablement. For the first try, it only activates HVS and couldn't "save" the SF to SF. When I re-run it is activated. Thus, as a workaround for my use case, I'm always running the command twice and it solves

from sfdx-browserforce-plugin.

github-actions avatar github-actions commented on June 11, 2024

🎉 This issue has been resolved in version 2.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

from sfdx-browserforce-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.