Giter Club home page Giter Club logo

Comments (3)

westonruter avatar westonruter commented on June 3, 2024 1

Yes, this is result of https://core.trac.wordpress.org/ticket/58775

We'll need to fix by the time WordPress 6.4 is released.

As for the fix, the code in question is:

amp-wp/includes/class-amp-theme-support.php

Lines 1228 to 1241 in 2c4df9e

remove_action( 'wp_head', $header_callback );
if ( '__return_false' !== $header_callback ) {
ob_start();
$header_callback();
$style = ob_get_clean();
$data = trim( preg_replace( '#<style[^>]*>(.*)</style>#is', '$1', $style ) ); // See wp_add_inline_style().
// Override AMP's position:relative on the body for the sake of the AMP viewer, which is not relevant an an Admin Bar context.
if ( amp_is_dev_mode() ) {
$data .= 'html:not(#_) > body { position:unset !important; }';
}
wp_add_inline_style( 'admin-bar', $data );
}

I believe it can be rewritten as follows, or something like it:

if ( ! function_exists( 'wp_enqueue_admin_bar_header_styles' ) ) {
    remove_action( 'wp_head', $header_callback );
}
 if ( '__return_false' !== $header_callback ) { 
 	if ( ! function_exists( 'wp_enqueue_admin_bar_header_styles' ) ) {
 		ob_start(); 
 		$header_callback(); 
 		$style = ob_get_clean(); 
 		$data  = trim( preg_replace( '#<style[^>]*>(.*)</style>#is', '$1', $style ) ); // See wp_add_inline_style(). 
 	} else {
 		$data = '';
 	}
  
 	// Override AMP's position:relative on the body for the sake of the AMP viewer, which is not relevant an an Admin Bar context. 
 	if ( amp_is_dev_mode() ) { 
 		$data .= 'html:not(#_) > body { position:unset !important; }'; 
 	} 
  
 	wp_add_inline_style( 'admin-bar', $data ); 
 }

from amp-wp.

westonruter avatar westonruter commented on June 3, 2024

cc @spacedmonkey

from amp-wp.

pavanpatil1 avatar pavanpatil1 commented on June 3, 2024

QA Passed ✅

Cross-verified the issue and the applied solution is functioning correctly. Now, the deprecation warning related to the _admin_bar_bump_cb is not visible.

Before After
image image

from amp-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.