Giter Club home page Giter Club logo

Comments (3)

sebastianbenz avatar sebastianbenz commented on August 18, 2024

This sounds like: ampproject/amphtml#15834. Did you enable the DevChannel when calculating the runtime version?

I don't think that this is an issue with AMP Optimizer, as the on attribute is still present in the template markup produced by the optimizer - the rest happens at runtime.

from amp-toolbox.

bjalford avatar bjalford commented on August 18, 2024

Thanks - agree that seems the likely cause.

No, we're using current version code below which generates this: https://cdn.ampproject.org/rtv/001528391646530/v0/amp-live-list-0.1.js

const AmpOptimizerMiddleware = require('amp-toolbox-optimizer-express');
const runtimeVersion = require('amp-toolbox-runtime-version');

const { corsEnabledUrl } = require('../config');

module.exports = function () {
  const optimiser = AmpOptimizerMiddleware.create({
    runtimeVersion: () => runtimeVersion.currentVersion()
  });

  return (req, res, next) => {
    const matched = corsEnabledUrl
      .concat(['/pwamp-preview'])
      .filter((path) => req.url.startsWith(path));

    if (matched.length > 0) {
      next();
      return;
    }
    optimiser(req, res, next)
  }
};

from amp-toolbox.

sebastianbenz avatar sebastianbenz commented on August 18, 2024

Closing this for now. Feel free to reopen in case it turns out that it's caused by Optimizer.

from amp-toolbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.