Platform is always overriden to Node.js about amplitude-node HOT 5 OPEN

For some reason your built files are incorrect. When I go to node_modules/@amplitude/dist/src/nodeClient.js I see:

Yet this code has been patched:

Yet the version I have installed is the latest version:

from amplitude-node.

Hey @tommedema !

We haven't published those changes - apologies. I'll go ahead and publish the newest version and close this once Node 1.3.3 is available!

from amplitude-node.

Ok, thanks @kelvin-lu -- and now that I have you, where am I supposed to set the user's browser and browser version?

If os_name and os_version (which would be really odd naming though seems to be what your documentation at https://developers.amplitude.com/docs/http-api-v2 suggests), where am I supposed to define the operating system name and version?

This is what I'm currently doing but it seems ugly and doesn't distinguish between browser name and version:

    platform: `${userAgent.browser.name}@${userAgent.browser.major}`,
    os_name: userAgent.os.name,
    os_version: userAgent.os.version,
    device_brand: userAgent.device.vendor,
    device_model: userAgent.device.model,

And this is the data that I have available:

"userAgent.browser.major": "88",
    "userAgent.browser.name": "Chrome",
    "userAgent.browser.version": "88.0.4324.146",
    "userAgent.engine.name": "Blink",
    "userAgent.engine.version": "88.0.4324.146",
    "userAgent.os.name": "Mac OS",
    "userAgent.os.version": "10.15.7",
    "userAgent.ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.146 Safari/537.36"

But it is unclear how to map these props to what Amplitude expects in the case of the browser name and version.

from amplitude-node.

@tommedema Let me confer with our dataPL team if we have any best practices but it looks close to what you have here - linking to what our Web SDK does here; we put the browser in the OS space and the OS info in the device.

what is userAgent.device.vendor look like? I don't think I see it in your available data

from amplitude-node.

Hmm, what you referred to me is actually different from what we're doing. It seems a bit awkward to say that the device model is MacOS, Windows, etc.? MacOS is an operating system, not a device. A device might be an iPhone, Samsung Galaxy S8, etc.

Even though it might not make sense to set the OS as the device, should we do this anyway since this seems to be what the web sdk does? FYI - seems like the web guys realize this is not correct

userAgent.device.vendor will be undefined unless you are on a mobile device, in which case it will be e.g. "Samsung", "Nokia", etc.

We use ua-parser-js to retrieve these properties from the user agent

from amplitude-node.