Giter Club home page Giter Club logo

Comments (9)

kelvin-lu avatar kelvin-lu commented on August 20, 2024 1

Sorry for the inconvenience @nvuillam - we'll work rightaway to get the @amplitude/utils onto the registry. As for the multiple http calls, we're looking to use the batch endpoint as the default on an open pr (along with some logic for retrying events in the correct order).

from amplitude-node.

Vadorequest avatar Vadorequest commented on August 20, 2024 1

Is there any example/doc about how to use this feature? (multiple events in one HTTP call)

from amplitude-node.

nvuillam avatar nvuillam commented on August 20, 2024

mmmm I see that this package looks much more advanced, and already provides requested feature ....

https://github.com/geoffdutton/amplitude

I'll try to use it and tell here if i still need the enhancement ! ( i started to do it but npm install fails because package @amplitude/utils is not available on npm registry )

from amplitude-node.

nvuillam avatar nvuillam commented on August 20, 2024

I made some tests using amplitude npm package, it seems to work for now :)
But as your library seems more lightweight, I may switch back to it once you publish an update :)

from amplitude-node.

kelvin-lu avatar kelvin-lu commented on August 20, 2024

Thanks @nvuillam ! We're looking forward to having an update soon. While we are discussing having mutliple events being sent in logEvent, it's also good to note that logEvent by default (in the new version) waits until the next event loop to batch and send all the events its collected - so as to avoid many many http calls. You can also set the option for it to wait even longer for the batch time to increase and send more events at a time.

from amplitude-node.

kelvin-lu avatar kelvin-lu commented on August 20, 2024

Hi @nvuillam - the 1.0.2 behavior is for events to be batched by logEvent and not be sent until a certain amount of time passes, or flush is called - I think this might be a suitable solution for your use?

from amplitude-node.

nvuillam avatar nvuillam commented on August 20, 2024

Is the HTTP request done by a separate node instance ? If not, it could be not ok for CLIs , because it wouldn't exit until such batch is processed

from amplitude-node.

kelvin-lu avatar kelvin-lu commented on August 20, 2024

@nvuillam apologies for the late response!
It's using setTimeout to wait some number of seconds in the same node instance, so the concern here is valid. We're adding optioning to make the timings of these waits more configurable - what do you think? We'll also start looking into putting some of this logic in separate node instances.

also, the base optioning is to wait 0 ms - to the next event loop.

from amplitude-node.

viqueen avatar viqueen commented on August 20, 2024

While logEvent does batching under the hood, it's a little bit counter intuitive when we actually care about the response body.
My understanding it calls this API https://developers.amplitude.com/docs/batch-event-upload-api , which makes my response handlers a little bit confusing to write

from amplitude-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.