Missing events even with flush about amplitude-node HOT 3 OPEN

@florian-milky the skipped response should only be returned from flush when either there are no events remaining in the buffer, or the events are incorrectly formatted. Where is it that you notice events are missing? Are they not appearing on the amplitude website?

from amplitude-node.

@ajhorst I log something when the promise is resolved. So I got like 13 logs right before logEvents, and then I got like 10 logs that the promise resolved. Then the flush resolves. On amplitude website I don't see events that didn't resolve.

Now I double checked my code and I realise I expected the promise to throw because I was using async/await, but when I stopped awaiting the logEvent, I removed the async/await which means the code is not gonna throw anymore 🤦

So I'll handle that and check why it is throwing.

Edit: ok obviously not fully awake yet. I am not catching the promise so it would fail if one of them would throw.

Some code:

export function logMetrics(metrics) {
  console.log(`Logging metrics into ${process.env.ENV}`, metrics);
  client
    .logEvent({
      event_type: 'KPI - PageSpeed audit',
      user_id: 'lambda-lighthouse',
      event_properties: metrics,
    })
    .then((r) => console.log(metrics.target, r));
}

   // iterating over some stuff and calling logMetrics

    console.log('Flushing metrics to amplitude');
    const response = await flush();
    if (response.status !== Status.Success && response.status !== Status.Skipped) {
      console.log('Flushing did not work', response);
      throw new Error('Could not flush amplitude events');
    }
    console.log('Flushed', { status: response.status });

from amplitude-node.

@florian-milky are there any console warnings in your browser window when you try this?

from amplitude-node.