Giter Club home page Giter Club logo

Comments (12)

maxalmonte14 avatar maxalmonte14 commented on June 3, 2024 1

Great, I'll try to implement this solution, and then add some tests ✌️

from todolist.

amoraitis avatar amoraitis commented on June 3, 2024 1

Thank so much for your contribution @remcoe, I will review in the next 1 or 2 days.

from todolist.

abc516 avatar abc516 commented on June 3, 2024 1

Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?

from todolist.

amoraitis avatar amoraitis commented on June 3, 2024 1

Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?

Hi, please check for areas not covered yet. I am pretty sure that the TodoItemService is not covered.

from todolist.

maxalmonte14 avatar maxalmonte14 commented on June 3, 2024

Hi buddy, I like your project, looks very nice indeed 👌

I would like to contribute to it, especially in this particular issue (which is testing coverage).

I have a little question about it, I cloned the project and when I tried to run it, just exploded 😅

I'm using an Ubuntu 16.04 based Linux distribution and I got the following error after logging in:

PlatformNotSupportedException: LocalDB is not supported on this Platform.

Does that mean that the app doesn't run on Linux? The answer looks pretty obvious to me, it would be nice adding Linux support, Thanks to .NET Core should be easy peasy.

from todolist.

amoraitis avatar amoraitis commented on June 3, 2024

@maxalmonte14
Temporary solution: I think that you can use InMemoryDatabase for linux without adding it to Version Control.

I will, also, move to sqlite on the next commit

from todolist.

maxalmonte14 avatar maxalmonte14 commented on June 3, 2024

I'm still on this, I'm having a hard time trying to test async methods, also trying to mock dependencies like DbContext, I have to get use to C# testing tools, but eventually I will make a PR. ✌️

from todolist.

amoraitis avatar amoraitis commented on June 3, 2024

@maxalmonte14 please use docs. Start with this one

from todolist.

reerden avatar reerden commented on June 3, 2024

I created a PR :) #31

from todolist.

jezmaghuyop avatar jezmaghuyop commented on June 3, 2024

Hi, do you still need help with this?

from todolist.

amoraitis avatar amoraitis commented on June 3, 2024

@jezmaghuyop This will remain open, we always want better test coverage for the project.

So, feel free to add you tests.

from todolist.

pdelcogliano avatar pdelcogliano commented on June 3, 2024

Hi @amoraitis. Will you please assign this issue to me? I am using #hacktoberfest to get into the OSS community. I think this is a great task for me to work on. BTW, can you also create an issue item to port the code to dot net 7? If you create that issue, you can assign that one to me too. Thanks!

from todolist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.