Comments (12)
Great, I'll try to implement this solution, and then add some tests ✌️
from todolist.
Thank so much for your contribution @remcoe, I will review in the next 1 or 2 days.
from todolist.
Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?
from todolist.
Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?
Hi, please check for areas not covered yet. I am pretty sure that the TodoItemService is not covered.
from todolist.
Hi buddy, I like your project, looks very nice indeed 👌
I would like to contribute to it, especially in this particular issue (which is testing coverage).
I have a little question about it, I cloned the project and when I tried to run it, just exploded 😅
I'm using an Ubuntu 16.04 based Linux distribution and I got the following error after logging in:
PlatformNotSupportedException: LocalDB is not supported on this Platform.
Does that mean that the app doesn't run on Linux? The answer looks pretty obvious to me, it would be nice adding Linux support, Thanks to .NET Core should be easy peasy.
from todolist.
@maxalmonte14
Temporary solution: I think that you can use InMemoryDatabase for linux without adding it to Version Control.
I will, also, move to sqlite on the next commit
from todolist.
I'm still on this, I'm having a hard time trying to test async methods, also trying to mock dependencies like DbContext
, I have to get use to C# testing tools, but eventually I will make a PR. ✌️
from todolist.
@maxalmonte14 please use docs. Start with this one
from todolist.
I created a PR :) #31
from todolist.
Hi, do you still need help with this?
from todolist.
@jezmaghuyop This will remain open, we always want better test coverage for the project.
So, feel free to add you tests.
from todolist.
Hi @amoraitis. Will you please assign this issue to me? I am using #hacktoberfest to get into the OSS community. I think this is a great task for me to work on. BTW, can you also create an issue item to port the code to dot net 7? If you create that issue, you can assign that one to me too. Thanks!
from todolist.
Related Issues (20)
- Migrate to ASP.NET CORE 2.2
- User is never signed in HOT 6
- [Bug] EmailSender service should not send an email when a SendGrid API key isnt set
- Create a public home, about and contact us page HOT 7
- Create ToDo from web is failing due to UserId is null HOT 2
- Change array types to generic types in our model classes HOT 1
- Project architecture improvements: Introduce TodoList.Core HOT 2
- Project architecture improvements: Introduce TodoList.Api HOT 2
- [Suggestion] Use AutoMapper for object-object mapping HOT 6
- Localization usage over the web app HOT 4
- UI refresh HOT 5
- [Feature] Extend calendar view functionality HOT 2
- Project architecture improvements: Consume new REST API HOT 1
- [Defect] Change how the user secrets are currently deployed. HOT 3
- [Suggestion] Microsoft.Web.LibraryManager.Cli should be mentioned within the setup steps. HOT 3
- [Ideas] Xamarin app creation HOT 4
- Add ability to show holidays in calendar view. HOT 10
- Where are the repository classes for the project?
- Project does not build due to libman dependency HOT 2
- .env file is open to the public with a simple google search
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from todolist.