Giter Club home page Giter Club logo

Comments (16)

amilajack avatar amilajack commented on September 3, 2024 3

I am not sure how butter-desktop solves this problem. They aren't using WebChimera.js. Here are the possible solutions that I have found:

  1. Build electron from source with support for proprietary codecs. Pros: significant amount of bugs fixes because of the lack of bindings. Essentially, this will add native electron/chromium support for currently unsupported codecs, like mkv. This means no more WebChimera. Cons: Have to look into the legality of this. This also means that we need to manually build electron. Furthermore, supporting non-standard codecs might cause our build to become unstable.
  2. @jayke-vbh 's 'dirty hack': RSATom/WebChimera.js#69 (comment). Pros/Cons should be the same as 1.
  3. Fallback to https://github.com/duanyao/codecbox.js. The issue with this is that I feel that the project is inactive and it doesnt provide bindings. Its also extremely slow, primarily because its not optimized well. The benefit of this is that it is guaranteed to work, regardless of OS or environment, because it is asm.js. Optimizing this requires knowledge of C++ and WebGL, which I do no understand at all.

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Oh right. WebChimera.js does not support Linux at the moment :(

RSATom/WebChimera.js#69

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Does it work on Windows?

from popcorn-time-desktop.

thangngoc89 avatar thangngoc89 commented on September 3, 2024

@amilajack on Windows it stucks at build step for node-gyp. I can't find a workaround for it. And developing node app on Windows is terribly slow.

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Hmm WebChimera.js is an optional dependency. Does it throw an error and quit the npm entire installation process?

from popcorn-time-desktop.

thangngoc89 avatar thangngoc89 commented on September 3, 2024

I checked out release-0.0.3-alpha branch. Now it's working

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Oh right. The dev-master and master haven't been merged yet. Waiting for ci to finish before i merge. Appveyor takes forever

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Actually I think it would be best to reopen this issue and rename it to 'WebChimera.js Linux support/fallback'

from popcorn-time-desktop.

thangngoc89 avatar thangngoc89 commented on September 3, 2024

Sounds good to me

from popcorn-time-desktop.

thangngoc89 avatar thangngoc89 commented on September 3, 2024

No idea how but PowerPlayer supports Linux. See https://github.com/jaruba/PowderPlayer/releases

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Its using an older version of electron (0.37.6). This was the version of electron that WebChierma.js works on.

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

@thangngoc89 added some initial support for this in the 'torrent wins'.

Make sure you have vlc player installed first.

git pull --all
git checkout torrent-wins
npm i
npm run dev

This should work for any tv show or torrent. All you need to do is select the 'vlc' option in the dropdown under the star rating.

from popcorn-time-desktop.

thangngoc89 avatar thangngoc89 commented on September 3, 2024

Ollie. Sounds good

from popcorn-time-desktop.

thangngoc89 avatar thangngoc89 commented on September 3, 2024

So you'll go for a custom build of Electron right?

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Its something similar. I'll replace some files during installation.

from popcorn-time-desktop.

amilajack avatar amilajack commented on September 3, 2024

Fixed in release 0.0.5

from popcorn-time-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.