Giter Club home page Giter Club logo

Comments (3)

randomPoison avatar randomPoison commented on June 17, 2024

Ah, thanks for finding this! I'm pretty sure I've run into this issue and hadn't yet figured out where the crash was coming from. We could fix this with UDP pretty easily by splitting the message across multiple packets, though this also makes me want to investigate using proper IPC communication or maybe even TCP.

Ideally ipc-channel would be the way to go, but Windows support is still a work in progress. So in the meantime I'd probably suggest we go with TCP, since I think that will be the easiest for editor implementations to support.

from editor-core.

randomPoison avatar randomPoison commented on June 17, 2024

This would also be a good thing to add a regression test for!

from editor-core.

randomPoison avatar randomPoison commented on June 17, 2024

Thinking about it a bit more, it's not going to be so trivial to convert to TCP 🤔 With TCP we'd have to manually manage connection states, send heartbeats, and track disconnections after a timeout. This is stuff we'll want to do eventually, but I'm not sure it's worth putting in that kind of effort for now. Instead I'm going to doing a pretty simple implementation of splitting the state message across multiple UDP packets.

from editor-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.