Image comparison of snapshots crashes node v9.2.0 about jest-image-snapshot HOT 5 CLOSED

On my project, I am just getting screenshot tests integrated for the first time, so having a blocker like this right when I am getting the test environment set up was very disruptive for me. I needed to move forward, and I have found a small, temporary work around for now.

I made a local copy of this Jest Matcher in my project, so I could change the pngjs dependency to its fork, pngjs-nozlib. This fork was a drop in replacement. Doing this, I was able to work around this issue for now, although I have no idea how much of an impact this change will have with respect to compression, speed, or accuracy.

EDIT: Sorry about the below misclick

from jest-image-snapshot.

@adrianmcli The only thing that can be done from the Jest-image-snapshot side would be to use a different library than pngjs (maybe using the solution @Kraxxis has) but I need to evaluate our choices first and make sure no regressions are caused by the switch. I’ll do that today.

from jest-image-snapshot.

Thanks for bringing this to my attention. I’ll be tracking the issue on the pngjs package and evaluating if there is anything I can do.

from jest-image-snapshot.

I’ll be tracking the issue on the pngjs package and evaluating if there is anything I can do.

@anescobar1991 any news on the progress of this bug? I am trying to deploy visual regression testing with this library, but I don't want to break the team's builds.

Perhaps we should integrate Kraxxis' workaround into this project?

from jest-image-snapshot.

Assuming that pngjs-nozlib really does work out of the box with node 9.x.x as @Kraxxis mentions (I have not tried myself) I think the right thing to do here is to open a PR to pngjs with the changes from pngjs-nozlib. It looks like the only thing pngjs would lose from that solution is backwards compatibility with node 0.10 which I am thinking the pngjs author may be okay with at this point as long as it is versioned appropriately.

Otherwise I don't feel comfortable using pngjs-nozlib in jest-image-snapshot as there is no guarantee of maintenance (as evidenced by fact that https://www.npmjs.com/package/pngjs-nozlib does not even point to the correct github repo). Aside from that sadly there are not really any pngjs alternatives available that I could find.

@Kraxxis or @adrianmcli do you mind looking into this?

from jest-image-snapshot.