Hello,
Isn't the Labels import missing from init.py file ?
This might be my lack of python knowledge however so please excuse me in case this is not true.

Steps:

1. go to https://new-relic-api.readthedocs.io/

Current behavior

• user gets 404

Can you please make the docs available?

I think this is an actual bug in the documentation but testing with requests shows that this works:

requests.get('https://api.newrelic.com/v2/servers.json', headers={'X-Api-Key':'key'}, data={'filter[labels]':'Type:Elasticsearch'}).json()

While this which looks like it is what this project is currently using, doesn't:

requests.get('https://api.newrelic.com/v2/servers.json?filter[labels]=Type:Elastisearch', headers={'X-Api-Key':'key'}).json()

#46

Following the example in the docs for moving an application to a different policy, I am attempting to move a server to a different policy. My code is as follows.

! /usr/bin/python

from newrelic_api import AlertPolicies, Servers

server_id = Servers().list(
filter_name='<server_name>'
)['servers'][0]['id']

non_notify_policy = AlertPolicies().list(
filter_name='<policy_name>',
filter_type=['server'],
filter_enabled=True
)['alert_policies'][0]

server_in_policy = server_id in non_notify_policy.get('links', {}).get('servers')

if not server_in_policy:
server_ids = non_notify_policy['links']['servers']
server_ids.append(server_id)

new_alert_policy = non_notify_policy.copy()
new_alert_policy['links']['servers'] = server_ids

AlertPolicies().update(
    id=new_alert_policy['id'],
    policy_update=new_alert_policy
)

When run I get the following errors.

/usr/bin/python2.7 /home/user/PycharmProjects/new_relic_maintenance_mode_disable_alerts/new_relic_maintenance_mode_disable_Alerts
Traceback (most recent call last):
File "/home/user/PycharmProjects/new_relic_maintenance_mode_disable_alerts/new_relic_maintenance_mode_disable_Alerts", line 25, in
policy_update=new_alert_policy
File "/home/user/.local/lib/python2.7/site-packages/newrelic_api/alert_policies.py", line 239, in update
data=policy_update
File "/home/user/.local/lib/python2.7/site-packages/newrelic_api/base.py", line 71, in _put
raise NewRelicAPIServerException('{}: {}'.format(response.status_code, response.text))
newrelic_api.exceptions.NewRelicAPIServerException: 400: {"error":{"title":"missing parameter: alert_policy"}}

Process finished with exit code 1

Would be great to introduce the ability to return data within a time range.

This functionality isn't available in the New Relic API Explorer, but works if you're calling it manually via CURL as per this doc https://docs.newrelic.com/docs/apis/rest-api-v2/requirements/extracting-metric-data

For example, the below would return the metrics between 05/09/2014 - 11/09/2015 in 1 hour periods;

-d'names[]=from=2015-09-05T10:00:00+00:00&to=2015-09-11T10:00:00+00:00&period=3600'

Python isn't my primary language, but I'lltry and submit a pull request myself unless someone thinks they can do it before me.

Currently alert_conditions.update(...) calls alert_conditions.list() to see if the condition already exists. If it doesn't exist, update(...) gives a NoEntityException with message: "Target alert condition is not included in that policy." That makes sense.

However, list() only returns the first page of conditions. If the condition we want to update exists on the second page, we will also receive the exception.

Instead, we want update() to look through all pages of conditions to see if the one we're trying to update exists.

This repo is out of date with New Relics APIs and seems to be no longer maintained @ambitioninc do you have any plans to keep this project going?

I work on a fork (https://github.com/sansible/newrelic-api) where we have been adding support for the current NR APIs, would it be possible to get these changes merged over here? Looking at the PRs on this repo it seems that nothing has been merged for a while.

Hi,

When I follow the docs to get alert policies, I get the following error:

Traceback (most recent call last):
File ".../newrelic_api/alert_policies.py", line 95, in list
params=self.build_param_string(filters)
File ".../newrelic_api/base.py", line 47, in _get
raise NewRelicAPIServerException('{}: {}'.format(response.status_code, response.text))
NewRelicAPIServerException: 410: {"error":{"title":"The alert policies API is deprecated. Please see 'alerts.newrelic.com' for the new alerting infrastructure."}}

Any idea why this is happening? When I test the GET query on New Relic's API Explorer or when I use Perl to import the data, I don't have any problems.
Maybe there is something wrong with the way the header parameters are created?

Is there some way to be able to use the pagination links which are returned in the Link header with the response?

Link: <https://api.newrelic.com/v2/servers.json?page=2>; rel="next", <https://api.newrelic.com/v2/servers.json?page=6>; rel="last"

I've got a lot of servers which I'd like to delete any which are not reporting, and I'm not really seeing a way to do that right now.

Thanks!

First of all, thank you for this excellent API client. I appreciate you guys sharing your good work.

Issue

Sometimes, NewRelic's API responds with Internal Server Error 500, which breaks the assumption that the response object's json() method will successfully return.

This is what happens now when the server errors:

client.update(6741145, name='blah')
*** JSONDecodeError: Expecting value: line 1 column 1 (char 0)

At this point, response.content contains an HTML document of the NewRelic homepage, probably just their default error handling page. This is not good API error implementation, and I've filed a issue with NewRelic support on this.

Recommendation

1. create custom exceptions to represent server errors gracefully (e.g. NewRelicAPIServerError)
2. if response.status != 200, raise NewRelicAPIServerError with helpful message

Scope

Here are all the places that could use a safety check:
https://github.com/ambitioninc/newrelic-api/search?utf8=%E2%9C%93&q=%22return+response.json%22&type=Code