Support isValidSignature(bytes, bytes) about signature-validator HOT 8 OPEN

@schmanu the EIP was updated to use bytes32, bytes and that's it's latest version AFAIK?

Also, using bytes as input presumes that the function would take input that isn't the final digest, but might not be compatible with different schemes (eg with prefix vs without prefix, in other words hash(ethereum signed message+hash(input)) vs hash(input)). Unless it is used for the final digest.

Anyway, we have nothing against implementing this, I'm just curious what the rationale is. Furthermore whether the input is the final digest affects the implementation

from signature-validator.

Hey @Ivshti, at the time the isValidSignaturecall was implemented in the safe-contracts the standard was still isValidSignature(bytes, bytes). That's why it is implemented in this way.

from signature-validator.

@schmanu can you give me an example of how it's used? are the first bytes the input to keccak256? Or is prefixing also done (Ethereum signed message)?

from signature-validator.

closing due to inactivity

@schmanu feel free to reopen if you feel strongly about this, especially if you're willing to PR it

from signature-validator.

At Snapshot we verify EIP-712, ERC-1271 (signatures on both old and new versions) and want to support ERC-6492

We found this library awesome library just today, and this library got everything we want to verify, except a check for signatures coming from older safe version, i.e checking for magic value 0x20c13b0b

Is there some way to get this added?

from signature-validator.

I think so, @ChaituVR: can you point to verification logic for the older safe version and we can try to get it implemented

from signature-validator.

Hey @Ivshti It is here https://github.com/snapshot-labs/snapshot.js/blob/master/src/verify/evm.ts#L72-L81

from signature-validator.