Comments (11)
If current tab has actions on keyboard (like escape key in telegram web) it overrides action in Omni, and Omni does not closing
Bro, just click outside the menu
It will exit
from omni.
Bro, just click outside the menu
I know, but there should be way to do it without mouse in that case
from omni.
Bro, just click outside the menu
I know, but there should be way to do it without mouse in that case
type something that gives 0 results [like hhhhhhhhhhhhhhh] and press enter
from omni.
I've been looking into this and honestly I haven't found a solution. I see on Telegram it requires pressing the Esc key two times to work, it can certainly be a bit annoying. Unsure if I can do anything about it, I considered making the Esc key an "official" command, but if you had an extension that was also using it that would cause issues. Would be interested to see if anyone knows how this could work - I'm assuming it's due to some event.stopPropagation() call?
from omni.
I've been looking into this and honestly I haven't found a solution. I see on Telegram it requires pressing the Esc key two times to work, it can certainly be a bit annoying. Unsure if I can do anything about it, I considered making the Esc key an "official" command, but if you had an extension that was also using it that would cause issues. Would be interested to see if anyone knows how this could work - I'm assuming it's due to some event.stopPropagation() call?
making an close Omni
command will do right?
from omni.
I've been looking into this and honestly I haven't found a solution. I see on Telegram it requires pressing the Esc key two times to work, it can certainly be a bit annoying. Unsure if I can do anything about it, I considered making the Esc key an "official" command, but if you had an extension that was also using it that would cause issues. Would be interested to see if anyone knows how this could work - I'm assuming it's due to some event.stopPropagation() call?
making an
close Omni
command will do right?
Yes, closeOmni() makes the omnisearch close, the problem is how to make it trigger on the Esc key when Telegram seems to prevent it from propagating.
from omni.
Wont making an action close Omni
that will call closeOmni() be acceptable?
from omni.
Or better, why not inject overide-hotkeys.js
to the webpage while initiating omni ?
from omni.
Wont making an action
close Omni
that will call closeOmni() be acceptable?
No, there are many ways to close Omni already (clicking outside the omnisearch, pressing Esc, and pressing on the extension icon), and they all should work.
Or better, why not inject
overide-hotkeys.js
to the webpage while initiating omni ?
This wouldn't solve anything, the keypress event would still not propagate.
from omni.
overide-hotkeys.js
onkeydown = function(e){
if(e.escKey.charCodeAt(0)){
e.preventDefault();
}
}
ig this would work
from omni.
onkeydown = function(e){ if(e.escKey.charCodeAt(0)){ e.preventDefault(); } }
Doesn't quite work, I ended up doing a different thing though and managed to fix it. A bit weird but basically listening for the keyup event outside jQuery did work, so I used that and then closed it through there.
from omni.
Related Issues (20)
- What is the logic of direct search results?
- [Suggestion] Add command to move tab to another window HOT 1
- favIconUrl is sometimes undefined on action (tab) (Firefox only?) HOT 1
- Option to remove a bookmark
- Google Docs Header Switching
- [Suggestion] Add chatGPT command
- Feature Request: Custom inputs for Commands HOT 1
- exams
- New bookmarks have not been updated
- Plugin doesn't open sometimes
- [feature request] fuzzy search
- Unexpected requests to `/users/undefined` causing unwanted 404 in Rails-based webapp
- The style displayed when bookmarking the protected script is incorrect
- Doesn't work in new tab
- how to open tab when search? HOT 1
- Feature Request: Integrate actions with Firefox Containers
- Chrome extension
- Some settings ?
- Dark mode not tied to system setting on macOS Ventura 13.6.4
- Invalid browser settings URI on Firefox
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from omni.