Giter Club home page Giter Club logo

Comments (9)

alyssaxuu avatar alyssaxuu commented on April 18, 2024

I'm open to changing it, if users don't mind. The only thing is I'm not sure what will happen with existing users, I wonder if it will stay the same for them. Otherwise it would be a big problem as Command+K wouldn't work anymore. So yeah hmm...

from omni.

danielcaldas avatar danielcaldas commented on April 18, 2024

Otherwise it would be a big problem as Command+K wouldn't work anymore

True, anyways you're already mentioning this in the README.md, so it shouldn't be too hard to find it.

ou can change the shortcut by going to chrome://extensions/shortcuts

from omni.

alyssaxuu avatar alyssaxuu commented on April 18, 2024

I could maybe make it super prominent after you install the extension somehow, like "are you ok using command+k or do you want to change this?". But there's plenty of users who just automatically close the page anyway, so might not be that effective.

from omni.

danielcaldas avatar danielcaldas commented on April 18, 2024

But there's plenty of users who just automatically close the page anyway, so might not be that effective.

Maybe keep monitoring, if you see users are looking a lot at this issue, that will give you the hint that something should be done about it.

Thanks for the extension btw, great work.

from omni.

edgarasben avatar edgarasben commented on April 18, 2024

True. Many websites including Tailwind CSS or Vercel Dashboard have the same quick search shortcut (Command+K). This plugin would prevent accessing the common website functionality.

One idea could be to display a text saying that users would have to press Command+K again to jump to the website's provided quick search bar. But actually I find it annoying, e.g. when Stripe documentation overrides the default Command+F page search shortcut:
image

On the other hand, this could be a good in-between solution that others might like (and Stripe decided to do it, so maybe it's not that bad)

from omni.

alyssaxuu avatar alyssaxuu commented on April 18, 2024

Just changed it to Cmd/Ctrl+Shift+K. I've looked it up and it shouldn't change the shortcut for users who already have the extension installed, so should be fine.

from omni.

edgarasben avatar edgarasben commented on April 18, 2024

Thank you for the update. Sorry to raise this again, but what should user do if they have another extension (e.g. Notion Web Clipper) using the same "Cmd/Ctrl+Shift+K" shortcut, but wanting to access Omni? Could they maybe customize the shortcut?

Otherwise the only option is to disable, in this case Notion Web Clipper.

from omni.

alyssaxuu avatar alyssaxuu commented on April 18, 2024

Thank you for the update. Sorry to raise this again, but what should user do if they have another extension (e.g. Notion Web Clipper) using the same "Cmd/Ctrl+Shift+K" shortcut, but wanting to access Omni? Could they maybe customize the shortcut?

Otherwise the only option is to disable, in this case Notion Web Clipper.

You can change the shortcut here: chrome://extensions/shortcuts

from omni.

edgarasben avatar edgarasben commented on April 18, 2024

I was not aware! Thanks!

from omni.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.