Giter Club home page Giter Club logo

Comments (8)

alyssaxuu avatar alyssaxuu commented on April 24, 2024 2

I wasn't sure whether to include the history results by default. I made it searchable using the command only to avoid showing any sensitive data. Some users have raised concerns about the extension even having access to the browser history to begin with (for privacy reasons), so I am not sure how to feel about it.

Open to changing it though, unsure what people think!

from omni.

Explosion-Scratch avatar Explosion-Scratch commented on April 24, 2024 1

Yeah, could work. I think ideally I'd like to have a way for users to decide what they want to see, so they can customize if they see bookmarks, history, actions... and even in which specific order they want it to be. Not sure where that could go though, it would have to be prompted after install and accessible somewhere, probably as an action in the omnisearch, but maybe also through a popup by clicking on the icon in the toolbar, not sure.

Options page might be nice? That could also have other settings that would make the ux a little nicer in general like:

  • Themes (custom too?)
  • Icon theme (instead of emojis maybe some phosphor icons or something)
  • Search mode (for slow/fast computers)
    • Fuzzy
    • Exact
  • What to search:
    • Bookmarks
    • History
    • Tabs
    • (request optional permissions if needed when checking)
  • Revoke permissions button (revokes all except tabs)
  • Customize keyboard shortcuts (might be tricky to implement though)

Perhaps settings could use something like this:
https://github.com/Explosion-Scratch/tab_grouping/blob/main/settings.html#L3-L11 (see settings.js for the code which I used to keep track of changes)

from omni.

wll8 avatar wll8 commented on April 24, 2024 1

Try typing /history before searching:

image

from omni.

Explosion-Scratch avatar Explosion-Scratch commented on April 24, 2024

You could make some sort of dropdown on the left of the search bar, then when the user tries to activate history ask for an optional permission

from omni.

alyssaxuu avatar alyssaxuu commented on April 24, 2024

Yeah, could work. I think ideally I'd like to have a way for users to decide what they want to see, so they can customize if they see bookmarks, history, actions... and even in which specific order they want it to be. Not sure where that could go though, it would have to be prompted after install and accessible somewhere, probably as an action in the omnisearch, but maybe also through a popup by clicking on the icon in the toolbar, not sure.

from omni.

vladstudio avatar vladstudio commented on April 24, 2024

Maybe: ask for history permission, if granted – include history into search results?

from omni.

wll8 avatar wll8 commented on April 24, 2024

Also, maybe the previous code only searched from nearly 1000 history records. This should be a trade-off from the performance aspect, but the PR#70 should solve this problem, quickly search from all records, whether it is 20,000 or more Two hundred thousand.

from omni.

gal-checksum avatar gal-checksum commented on April 24, 2024

+1 on having history searched directly from the search bar.

from omni.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.