Giter Club home page Giter Club logo

Comments (4)

alphapapa avatar alphapapa commented on July 28, 2024 1

Thanks for the quick answer! Indeed if I have an open buffer it seems to works fine. The value of helm-org-rifle-close-unopened-file-buffers is t (default value), but if I set it to nil it all works even if the buffer isn't open.

Yep, that's how it's supposed to work.

However I also tried to use let to locally set the variable inside the helm-org-rifle-open-in-brain function, but that didn't seem to work.

That's not the correct scope in which to bind the variable. It must be bound around the search command, not the action command.

I've actually fiddled a little bit with org-ql too. It seems like a really nice package, and I've thought about the possibility of using it as the "search engine" for org-brain since that would probably declutter the code. However org-brain has this concept of "file entries" (the part above the first headline in a file) which org-ql (and org-mode in general) doesn't seem to handle very well.

org-ql is intended to search outlines, not pre-outline matter in a file.

@Whil- has submitted a patch to org-mode which in my understanding will allow files to have an ID, properties, etc. That would probably make headlines and "file entries" more equal.

Yes, we've been discussing Gustav's proposal on the mailing list. Suffice it to say here that opinions are mixed. ;)

Another aspect is that I try to have few dependencies to other packages, but I'm starting to think that may be stubborn and dumb :)

For packages intended to be put in Emacs/Org core, that makes sense, but for MELPA packages, IMO it makes sense to use the available tools to simplify one's code.

I tried using org-sidebar to make a sidebar for org-brain (using the org-sidebar function with org-ql items). One issue here was that the sidebar seems to be in fundamental-mode, which seems odd to me.

The sidebar buffers have no natural major mode at this time; they aren't Org buffers, nor are they Agenda buffers. fundamental-mode is the default major mode for Emacs buffers.

I'll probably be rewriting org-sidebar's buffers to use more of org-ql, in which case they'll be org-ql-view buffers in org-agenda-mode.

from org-rifle.

Kungsgeten avatar Kungsgeten commented on July 28, 2024 1

From my understanding the package (helm-org-rifle) seems to work as intended. I had just missed the helm-org-rifle-close-unopened-file-buffers variable. Thank you for your help!

from org-rifle.

alphapapa avatar alphapapa commented on July 28, 2024

Hi Erik,

No problem, it might be a bug that needs to be fixed.

What's your setting for helm-org-rifle-close-unopened-file-buffers? Does it happen if you try to use the action on a candidate that's in a buffer which was already open when you called the helm-org-rifle-brain command?

BTW, you might also be interested in trying org-ql as a backend, since it's more powerful and faster than helm-org-rifle. Basically, the only advantage of helm-org-rifle at the moment is the way it displays context, which is a feature I may add to org-ql in the future.

from org-rifle.

Kungsgeten avatar Kungsgeten commented on July 28, 2024

Thanks for the quick answer! Indeed if I have an open buffer it seems to works fine. The value of helm-org-rifle-close-unopened-file-buffers is t (default value), but if I set it to nil it all works even if the buffer isn't open. However I also tried to use let to locally set the variable inside the helm-org-rifle-open-in-brain function, but that didn't seem to work.

I've actually fiddled a little bit with org-ql too. It seems like a really nice package, and I've thought about the possibility of using it as the "search engine" for org-brain since that would probably declutter the code. However org-brain has this concept of "file entries" (the part above the first headline in a file) which org-ql (and org-mode in general) doesn't seem to handle very well. @Whil- has submitted a patch to org-mode which in my understanding will allow files to have an ID, properties, etc. That would probably make headlines and "file entries" more equal. Another aspect is that I try to have few dependencies to other packages, but I'm starting to think that may be stubborn and dumb :)

I tried using org-sidebar to make a sidebar for org-brain (using the org-sidebar function with org-ql items). One issue here was that the sidebar seems to be in fundamental-mode, which seems odd to me.

from org-rifle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.