Recommend JS design patterns over others about gds-way HOT 7 CLOSED

In terms of actual style, I'd propose that we use the more immutable functional methods for data manipulation where possible.

Making use of ES5 .map() .filter() .reduce() .concat() .

Related:

• https://eloquentjavascript.net/1st_edition/chapter6.html
• http://cryto.net/~joepie91/blog/2015/05/04/functional-programming-in-javascript-map-filter-reduce/

from gds-way.

And voila: #119
Readable version: https://gist.github.com/maxf/b6ae33e35eb56e58df40d51a8759470a

from gds-way.

Not a comment about what style of JavaScript we recommend but a proposal for the upper limit of new JavaScript features we support.

I'd propose the following:

• Avoid stage-3 candidates and below
• Track the V8 version in the LTS Node.js release

This means avoiding transpiling entirely, and use only features natively available.

See https://zeit.co/blog/next#data-fetching-is-up-to-the-developer

"Our stance of what features we transpile (like async/await) can be summed up as: we target V8's capabilities. Since our goal is code-sharing between server and client, this gives us great performance when executing the code on Node and developing on Chrome or Brave, for example."

from gds-way.

We definitely need to expand the Node.js style guide to have a section on preferred JavaScript coding styles.

@Nooshu shared this link to a repo of best practices a couple of weeks back and we could just wholesale appropriate a lot of it as our own opinions.

We could enforce these opinions with an even more opinionated linter than Standard such as xo.

For instance xo prefers const over var (unless a let is appropriate) and also => vs function.

Right now on Pay we’re still on node 6.11.12 so we’re not doing any async/await stuff so I dunno what we’d say about that stuff.

from gds-way.

I can't find the article now, it was by Google or Mozilla.
But their argument for writing async/await was that they intend to optimise the implementation heavily in future so while it may be slower now, in future it will be the fastest way to handle async.

from gds-way.

I think I'll try and write something up, maybe during the next firebreak.

from gds-way.

Max's PR was merged, closing.

from gds-way.