Giter Club home page Giter Club logo

Comments (6)

ian-howell avatar ian-howell commented on September 21, 2024

I've found that removing these 3 lines fixes the issue. I'd make a PR, but I honestly have no idea how any of this stuff works, so I imagine there's a reason for these lines:

if zstyle -T ":fzf-tab:$_ftb_curcontext" popup-smart-tab; then
fzf_opts+=(--bind=tab:up,btab:down)
fi

from fzf-tab.

Aloxaf avatar Aloxaf commented on September 21, 2024

Your fzf ui is not displaying correctly.
When the tmux popup is shown above the cursor, the fzf prompt should be at the bottom, then 'tab' behavior conforms to expectations. But in your screenshot, the fzf prompt is always at the top.

Have you ever set FZF_DEFAULT_OPTS anywhere?

from fzf-tab.

ian-howell avatar ian-howell commented on September 21, 2024

Thanks for the quick response.

Yes, you're probably right. I'd forgotten that even though I was testing with the minimal zshrc, the FZF_DEFAULT_OPTS is exported, so it was getting passed to the child zsh shells.

I have this in my .zshrc:

export FZF_DEFAULT_OPTS="--height 40% --layout=reverse"

I will toy with it some more when I'm next at my keyboard. I'm going to leave this bug open until then (unless you're confident enough to close it).

from fzf-tab.

ian-howell avatar ian-howell commented on September 21, 2024

Unfortunately, it doesn't seem like that was it. I unset FZF_DEFAULT_OPTS and still saw the undesirable behavior. I tried a handful of different settings, as well as returning all of fzf's variables to default.

For what it's worth, I can't replicate this behavior using just fzf (nor it's ctrl-t or alt-c). The issue only occurs when I hit the TAB key and start fzf-tab.

from fzf-tab.

Aloxaf avatar Aloxaf commented on September 21, 2024

Very strange.

Can you replicate this behavior with tmux popup -E 'seq 10 | fzf'?

And how about change this line to fzf_opts+=(--bind=tab:up,btab:down --layout=default) and try again?

fzf_opts+=(--bind=tab:up,btab:down)

from fzf-tab.

ian-howell avatar ian-howell commented on September 21, 2024

I tried out tmux popup -E 'seq 10 | fzf', but it doesn't look like the TAB key works there by default...

However I do have some success with fzf_opts+=(--bind=tab:up,btab:down --layout=default. The popup still appears above the cursor, the first selection is at the bottom of the list, and TAB causes the cursor to move up the list:

fzf-tab-solution

This is much better, I would be ok with calling this an acceptable fix.

The behavior when I'm in the top tmux pane is the same as before (which is desired).

from fzf-tab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.