Giter Club home page Giter Club logo

Comments (13)

mikekavouras avatar mikekavouras commented on July 30, 2024 1

@alloy can confirm that this is fixed on master, but it doesn't look like it's been released. Fetching from rubygems.org still has the bug.

from lowdown.

alloy avatar alloy commented on July 30, 2024

That probably means that the topics field of the certificate may contain other values than I expected.

Care to make a PR for the format that your certificate holds?

from lowdown.

rayway30419 avatar rayway30419 commented on July 30, 2024

May I send my certificate by email?

from lowdown.

rayway30419 avatar rayway30419 commented on July 30, 2024

I find the others certifications topic is "$ + bundle_id"

from lowdown.

alloy avatar alloy commented on July 30, 2024

You don’t need to send me your certificate, you can check the value yourself like so:

$ irb -r openssl
irb(main):001:0> cert = OpenSSL::X509::Certificate.new(File.read('/path/to/certificate.pem')); nil
=> nil
irb(main):002:0> cert.extensions.find { |ext| ext.oid == '1.2.840.113635.100.6.3.6' }.value
=> "0d..net.artsy.artsy0...app..net.artsy.artsy.voip0...voip..net.artsy.artsy.complication0...complication"

from lowdown.

rayway30419 avatar rayway30419 commented on July 30, 2024

I got

"0...!com.kdanmobile.ipad.pdfreaderlite0...app.&com.kdanmobile.ipad.pdfreaderlite.voip0...voip..com.kdanmobile.ipad.pdfreaderlite.complication0...complication"

and lowdown default_topic

@default_topic="!com.kdanmobile.ipad.pdfreaderlite"

from lowdown.

alloy avatar alloy commented on July 30, 2024

Interesting, well it’s definitely clear where those ! and & characters are coming in from. I’m still not sure what they signify and feel like I might be overlooking a proper parser for the format of this value 🤔

But for now it should be easy enough for you to make a PR that adds entries formatted like yours to the tests and then make the parsing work for both cases.

from lowdown.

rayway30419 avatar rayway30419 commented on July 30, 2024

I thought it is not easy to me, but I will give it a try. :(

from lowdown.

rayway30419 avatar rayway30419 commented on July 30, 2024

Hi @alloy,

I find this situation occurs in other certificates, too.

If this parser is only want to grep the bundle id, why not just parse the subject? :(

I've tried to reproduce certifications and using other language to parse it but get the same result.

from lowdown.

alloy avatar alloy commented on July 30, 2024

@rayway30419 The reason that it’s not just the bundle ID is that a universal certificate may be used for more than 1 purpose. I pushed a fix that should be the right fix, let me know if it works for you.

from lowdown.

rayway30419 avatar rayway30419 commented on July 30, 2024

Hi @alloy
The fix by ASN1 looks well.
I thought you can commit this modification into rubygems. :)
thx

from lowdown.

sposin avatar sposin commented on July 30, 2024

Has this fix been released? We are experiencing this error (only in one of our apps).

from lowdown.

alloy avatar alloy commented on July 30, 2024

Hey, just got back from holiday.

My bad, I’ll put out a release this week. Thanks for reminding me.

from lowdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.