Giter Club home page Giter Club logo

Comments (5)

mathieutu avatar mathieutu commented on May 24, 2024 1

Actually I think that we can leave the noEmit like this, and let devs add --emitDeclarationOnly false if they need.
Also, I found out that the build option is not compatible with any config via console option (including strict), so no need to move anything.

Thanks for the cache thing!

13000 ts files

yep, and it's only the front 😅

from typescript-strict-plugin.

mathieutu avatar mathieutu commented on May 24, 2024

Hum actually --strict seems to not work with build at all. Investigating on that.
And for the emitDeclarationOnly, we can add --emitDeclarationOnly false

from typescript-strict-plugin.

KostkaBrukowa avatar KostkaBrukowa commented on May 24, 2024

About putting ...process.argv.slice(2) first makes more sense and I think it would solve the issue with first command line argument.
I believe that noEmit option makes the plugin run a bit faster (if noEmit is set to false in tsconfig), because we don't really need the file output and we only care about errors
The idea about cache is really great and it would actually speed up the process of tsc-scrict by 50%. I found the --listFiles option for the tsc and we would actually need to run tsc once and the difference between tsc-strict and tsc would be negligible. I'll make a PR for it.

Thanks for investigating

from typescript-strict-plugin.

KostkaBrukowa avatar KostkaBrukowa commented on May 24, 2024

Btw. 13000 ts files is hell a lot :D

from typescript-strict-plugin.

KostkaBrukowa avatar KostkaBrukowa commented on May 24, 2024

And about the noEmit flag I'm wondering what to do. Initially I've added the noEmit flag, because some project use babel to compile their projects and they don't have noEmit flag in their tsconfig. Without this flag running tsconfig would generate bunch of js files unnecessarily (default is false). So we have three options:

  1. Remove noEmit resulting in scenario above
  2. Leave like it is now resulting in error with compilation with tsconfig provided by you
  3. Search tsconfig and find if emitDeclarationOnly is present and don't add noEmit when it is

I think option 3 would be the best in this case, but I'm worring that there would be more cases like that with different flags. What do you think?

from typescript-strict-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.